• 13
    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      Now we need to press Refresh in browser to see new comments, builds, updates, etc on pull request page. Will be nice to have it automatically.

          Form Name

            [BSERV-4728] Live update of pull request page

            Hopeful added a comment -

            This same topic just bit us:

            As I was reviewing a Pull Request, the author pushed new changes.  I did not see the new changes, and the page did not refresh or warn me that what I was reviewing was 'out of date'.  I clicked "Approve" for the old material, which also approved the new material I had not seen.  The author saw my Approval, assumed I had seen all his changes, and merged.  I only found out about it later when I saw an email noting the push.  

            If you do add automatic refresh, please include an alert that something has changed.  A silent refresh is not enough.

            If you do not add refresh, please disable things like Approve, if a change has occurred on the server.

            Hopeful added a comment - This same topic just bit us: As I was reviewing a Pull Request, the author pushed new changes.  I did not see the new changes, and the page did not refresh or warn me that what I was reviewing was 'out of date'.  I clicked "Approve" for the old material, which also approved the new material I had not seen.  The author saw my Approval, assumed I had seen all his changes, and merged.  I only found out about it later when I saw an email noting the push.   If you do add automatic refresh, please include an alert that something has changed.  A silent refresh is not enough. If you do not add refresh, please disable things like Approve, if a change has occurred on the server.

            Hello,

            This issue is becoming more and more important for my day-to-day workflow.

            I have a particular issue with comments:

            1. I open the page of the PR
            2. look at the diff view
            3. then the PR submitter does a new push (with new content, either a new commit or even a rebase)
            4. then when I comment, my comments do not appear on the line that I commented

            I suppose the reason is that the comment gets attached against the line number. However, I commented against the old code which has a different line number than the new code pushed in the interim. So in the end my comment is attached to random location in the new code that was pushed. This is particularly annoying.

            1. the comments should follow the code (and not disappear from the global diff view like they do today)
            2. I should be told that code has changed and be offered to reload the page (Crucible could do that IIRC)

            JnRouvignac added a comment - Hello, This issue is becoming more and more important for my day-to-day workflow. I have a particular issue with comments: I open the page of the PR look at the diff view then the PR submitter does a new push (with new content, either a new commit or even a rebase) then when I comment, my comments do not appear on the line that I commented I suppose the reason is that the comment gets attached against the line number. However, I commented against the old code which has a different line number than the new code pushed in the interim. So in the end my comment is attached to random location in the new code that was pushed. This is particularly annoying. the comments should follow the code (and not disappear from the global diff view like they do today) I should be told that code has changed and be offered to reload the page (Crucible could do that IIRC)

            Hey,

            This is my experience with this:

            I pushed a new commit and while it appeared in the list of commits to choose from, selecting "All changes in the pull request" did not include the changes in that commit. I tried switching back and forth several times, from viewing changes in different commits (correct) to changes in the whole PR (incorrect).

            Workaround: full page refresh.

            I think this is a bug because the page magically updates with the new commit as I click around on the PR view, but shows an inconsistent state. This is made even worse because I might be lured into thinking that I am actually looking at all the changes and approve the PR without actually seeing the changes in the last commit.

            The page should either auto-update correctly or not auto-update at all, in which case the user will learn to refresh it manually to receive changes.

            Cheers,

            // Svante

            Svante Gustafsson Björkegren added a comment - Hey, This is my experience with this: I pushed a new commit and while it appeared in the list of commits to choose from, selecting "All changes in the pull request" did not include the changes in that commit. I tried switching back and forth several times, from viewing changes in different commits (correct) to changes in the whole PR (incorrect). Workaround: full page refresh. I think this is a bug because the page magically updates with the new commit as I click around on the PR view, but shows an inconsistent state. This is made even worse because I might be lured into thinking that I am actually looking at all the changes and approve the PR without actually seeing the changes in the last commit. The page should either auto-update correctly or not auto-update at all, in which case the user will learn to refresh it manually to receive changes. Cheers, // Svante

            Peter added a comment -

            Also, the "Merge" button is still deactivated after receiving enough approvals. A page refresh is required to make the button active.

            Peter added a comment - Also, the "Merge" button is still deactivated after receiving enough approvals. A page refresh is required to make the button active.

              Unassigned Unassigned
              3652ed9ede2e Alexey Efimov
              Votes:
              43 Vote for this issue
              Watchers:
              37 Start watching this issue

                Created:
                Updated: