Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-41814

Make ESC key behavior consistent across description and comment edit operations

    • 5
    • 1
    • Hide
      Atlassian Update – 19 June 2018

      Hi everyone,

      We have made the ESC key behaviour consistent for issue description and comments and this will be available with Jira Server 7.11.

      Starting from Jira Server 7.11, during inline editing, both description and comments being edited will NOT react after the ESC key is pressed.

      In the Create/Edit Issue dialog, the prompt pop-up is displayed after pressing ESC.

      The behaviour is consistent for both Visual and Text modes of RTE and Plain text editor.

      Kind regards,
      Katarzyna Derenda
      Product manager, Jira Server

       

      Show
      Atlassian Update – 19 June 2018 Hi everyone, We have made the ESC key behaviour consistent for issue description and comments and this will be available with Jira Server 7.11. Starting from Jira Server 7.11, during inline editing, both description and comments being edited will NOT react after the ESC key is pressed. In the Create/Edit Issue dialog, the prompt pop-up is displayed after pressing ESC. The behaviour is consistent for both Visual and Text modes of RTE and Plain text editor. Kind regards, Katarzyna Derenda Product manager, Jira Server  
    • We collect Jira feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      NOTE: This suggestion is for JIRA Server. Using JIRA Cloud? See the corresponding suggestion.

      Description:

      What happens currently when editing a description is that your edits are discarded if the Escape key is pressed.

      There are many reasons why the Escape key can be pressed by mistake in today's browser use and varied workflows, and so users end up losing their unsaved descriptions.

      Furthermore, Jira itself encourages the use of the Escape key to clear the focus of the current fields.

      If you click away from a description edit box to lose focus, your work is saved. However, if you use the Escape key to lose focus, your work is discarded. This is inconsistent behavior.

      The above behavior is in contrast to how editing comments behaves. When editing comments, navigating away whether by click, escape key, or page refresh, will popup an alert for the user to confirm their action (when there are changes to the comment).

      I'm not sure why editing comments is given so much more importance than editing issue descriptions, but both edit operations should behave consistent with eachother, as it is confusing for the user to have separate behaviors depending on what you edit.

      What should happen:

      1. Make editing issue descriptions behave the same way as when editing comments.

      • Alert box will show when there is risk of losing changes.

      2. As a way of allowing users to preserve current behavior with mininal disruption, provide users a way to configure the behavior of the ESC key in description boxes. Possible (but not exaustive) list of choices:

      • Escape to discard changes, no confirmation (Current behavior, should be default for existing accounts)
      • Escape to discard changes, require confirmation (Can be default for new accounts)
      • Escape to save changes, no confirmation (Alternatively, can be default for new accounts)
      • Escape only to lose focus but leaving text area in edit mode
      • Do nothing

      See: my previous comments for a longer rant on this topic.

            [JRASERVER-41814] Make ESC key behavior consistent across description and comment edit operations

            Hi everyone,

            After careful consideration, we've decided to prioritize making ESC key behaviour consistent across description and comment edit operations on Jira Server roadmap. 

            We hope to start development after our current projects are completed. Expect to hear an update on our progress within the next 6 months. 

            To learn more on how you suggestions are reviewed, see our updated workflow for server feature suggestions.

            Kind regards,

            Jira Server Product Management

            Kasia Derenda added a comment - Hi everyone, After careful consideration, we've decided to prioritize making ESC key behaviour consistent across description and comment edit operations on Jira Server roadmap.  We hope to start development after our current projects are completed. Expect to hear an update on our progress within the next 6 months.  To learn more on how you suggestions are reviewed, see our  updated workflow for server feature suggestions . Kind regards, Jira Server Product Management

            FWIW: My Jira user profile has a setting named "Keyboard shortcuts:". It is currently set to "Disabled". However, the Escape key still does something (i.e. discards my work).

            IMHO if I set "Keyboard shortcuts:" to "Disabled" the Escape key should do nothing.

            Maximilian Machedon added a comment - FWIW: My Jira user profile has a setting named "Keyboard shortcuts:". It is currently set to "Disabled". However, the Escape key still does something (i.e. discards my work). IMHO if I set "Keyboard shortcuts:" to "Disabled" the Escape key should do nothing.

            I'm getting this complain on a daily basis from dozens of people across my organization. I don't know what to say to them anymore. I just went through all the tickets and calculated more than 50 man hours of lost work since the beginning of this year.
            Having in mind the money we pay Atlansian every year I would expect a little more proactivity for correcting these small bugs from your part, instead of waiting for a bug report to be filled with a dozens of comments of angry people before you decided to act on it.

            Deleted Account (Inactive) added a comment - I'm getting this complain on a daily basis from dozens of people across my organization. I don't know what to say to them anymore. I just went through all the tickets and calculated more than 50 man hours of lost work since the beginning of this year. Having in mind the money we pay Atlansian every year I would expect a little more proactivity for correcting these small bugs from your part, instead of waiting for a bug report to be filled with a dozens of comments of angry people before you decided to act on it.

            +1. Just lost 10 minutes of work. I hit Alt + Tab to go to another window, then changed my mind and hit Escape while still holding Alt. Apparently even Alt + Escape will discard all edits to an issue description.

            This issue has been open for two and a half years. It's wasting a lot of people's time. It should be simple to add a warning. There have been many other updates to JIRA. What's the hold up for this simple one that adds huge value?

            Andrew Wilkinson added a comment - +1. Just lost 10 minutes of work. I hit Alt + Tab to go to another window, then changed my mind and hit Escape while still holding Alt. Apparently even Alt + Escape will discard all edits to an issue description. This issue has been open for two and a half years. It's wasting a lot of people's time. It should be simple to add a warning. There have been many other updates to JIRA. What's the hold up for this simple one that adds huge value?

            +1 just lost 31 minutes of work

             

            Steven Giguere added a comment - +1 just lost 31 minutes of work  

            +1 just lost 30 minutes of work.

            Nick Wertzberger added a comment - +1 just lost 30 minutes of work.

            Just lost a couple of hours work because I hit the "context menu" key on my keyboard, then instinctively closed it with ESC. However the ESC event also bubbled up to JIRA and destroyed all my work.

            Please add a confirmation prompt! Every other edit screen in JIRA seems to have one...

            Chris Butler added a comment - Just lost a couple of hours work because I hit the "context menu" key on my keyboard, then instinctively closed it with ESC. However the ESC event also bubbled up to JIRA and destroyed all my work. Please add a confirmation prompt! Every other edit screen in JIRA seems to have one...

            JP Dicks added a comment -

            Yes, it's really terrible behavior. I've also described the problem here: JRA-61439

            An extremely simple solution to all of these problems is just to prompt user to confirm action if there are unsaved changes.
            Even Microsoft gets this right

            JP Dicks added a comment - Yes, it's really terrible behavior. I've also described the problem here: JRA-61439 An extremely simple solution to all of these problems is just to prompt user to confirm action if there are unsaved changes. Even Microsoft gets this right

            Yahoo Serious added a comment - - edited

            This has been spread over so many issues, that all alarms should be going off. However, maybe it helps to collect all causes, symptoms, and alternatives suggested? (Probably not.) Especially since the motivations for current behavior, only consider a prompt-alternative, and I see more (see last part).

            Motivations for current behavior

            • "inline edit should be fast and simple in use"
            • "The majority of people actually use the Esc button as a path to cancel their actions"
            • a prompt would probably "slow down the majority of use-cases"
            • "We wanted to provide our users the ability to use it without thinking how they should behave and what they should do next while editing." [SIC]
            • "(...) use of escape as a shortcut in dialog boxes for No, Quit, Exit, Cancel, or Abort, as well as a common shortcut key for the Stop button in many web browsers".
            • "I can't find another way how we could do it better, so the solution would be acceptable to you and other users out there"

            Motivations for different behavior

            • losses are too many and too large to ignore
            • inconsistency with "Comments" and "Shares"
            • ESC to another popup is not always 'stopped', but bubbles/propagates to Jira
            • expected behavior was loosing focus while saving the content
            • can not be disabled by disabling Keyboard Shortcuts
            • too many accidents can happen (see 'Reasons' below)
            • external editor (alternative) has no preview (formatting)
            • 'Edit' is not a Dialog box

            Reasons to press escape without wanting to cancel

            • ESC-aping something else
              • trying to ESC-ape something on one window, but accidentally Jira has the keyboard focus (esp. with multiple monitors)
              • ESC-ape mistyped Chinese characters
              • ESC-ape spelling suggestion by browser
              • ESC-ape popup which displays on top without getting focus
              • ESC-ape dialog for saving webpage (Ctrl-S)
            • wrong shortcut: VI-users
            • mistyping:
              • missed from tilda (ESC-ape is close to it on many keyboards)
              • ESC-aping from Alt-Tab, but hit ESC twice? (or long?)
              • press Ctrl-ESC, but hitting ESC first? (Ctrl-ESC = shortcut Windows Start Menu)

            Alternatives/work-arounds

            • configurable ESC-behavior
              • user can configure choose behavior of ESC
              • user can set different shortcut for "abort" (e.g. CTRL/ALT-ESC)
              • user can disable by disabling Keyboard Shortcuts
              • adapt ESC-behavior upon certain amount of changes
            • enable restore/undo
              • add "undo" button (back, ...)
              • remember last changes (like re-entering edited "Share") when restarting Edit
              • remember personal history of a few last canceled text edits
            • ask confirmation to prevent loss
              • always prompt on ESC-aping changes (like leaving edited "Comments")
              • prompt on ESC-aping upon certain amount of changes

            BTW: Typed and (re)editted in Notepad++

            Yahoo Serious added a comment - - edited This has been spread over so many issues, that all alarms should be going off. However, maybe it helps to collect all causes, symptoms, and alternatives suggested? (Probably not.) Especially since the motivations for current behavior, only consider a prompt-alternative, and I see more (see last part). Motivations for current behavior "inline edit should be fast and simple in use" "The majority of people actually use the Esc button as a path to cancel their actions" a prompt would probably "slow down the majority of use-cases" "We wanted to provide our users the ability to use it without thinking how they should behave and what they should do next while editing." [SIC] "(...) use of escape as a shortcut in dialog boxes for No, Quit, Exit, Cancel, or Abort, as well as a common shortcut key for the Stop button in many web browsers". "I can't find another way how we could do it better, so the solution would be acceptable to you and other users out there" Motivations for different behavior losses are too many and too large to ignore inconsistency with "Comments" and "Shares" ESC to another popup is not always 'stopped', but bubbles/propagates to Jira expected behavior was loosing focus while saving the content can not be disabled by disabling Keyboard Shortcuts too many accidents can happen (see 'Reasons' below) external editor (alternative) has no preview (formatting) 'Edit' is not a Dialog box Reasons to press escape without wanting to cancel ESC-aping something else trying to ESC-ape something on one window, but accidentally Jira has the keyboard focus (esp. with multiple monitors) ESC-ape mistyped Chinese characters ESC-ape spelling suggestion by browser ESC-ape popup which displays on top without getting focus ESC-ape dialog for saving webpage (Ctrl-S) wrong shortcut: VI-users mistyping: missed from tilda (ESC-ape is close to it on many keyboards) ESC-aping from Alt-Tab, but hit ESC twice? (or long?) press Ctrl-ESC, but hitting ESC first? (Ctrl-ESC = shortcut Windows Start Menu) Alternatives/work-arounds configurable ESC-behavior user can configure choose behavior of ESC user can set different shortcut for "abort" (e.g. CTRL/ALT-ESC) user can disable by disabling Keyboard Shortcuts adapt ESC-behavior upon certain amount of changes enable restore/undo add "undo" button (back, ...) remember last changes (like re-entering edited "Share") when restarting Edit remember personal history of a few last canceled text edits ask confirmation to prevent loss always prompt on ESC-aping changes (like leaving edited "Comments") prompt on ESC-aping upon certain amount of changes BTW: Typed and (re)editted in Notepad++

            Bump for bad UI. Lost another 10 liner.
            Seems like a quick js hack to turn it into double escape in succession or cmd+esc / alt+esc.

            Jaime Urteaga added a comment - Bump for bad UI. Lost another 10 liner. Seems like a quick js hack to turn it into double escape in succession or cmd+esc / alt+esc.

              mdyro 🦊 Fox (Inactive)
              dfb61e047700 Cosmin Stroe
              Votes:
              46 Vote for this issue
              Watchers:
              38 Start watching this issue

                Created:
                Updated:
                Resolved: