Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-7108

adding reviewers group conflicts with allowed groups

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • 4.1.0
    • 3.7.0
    • None

      The feature to add group of users as reviewers to CRUC-474 seems to be conflicting when the project has allowed users/groups restriction.

      Basically with no users/groups restriction user can filter users/groups by its name prefix in the Edit Review dialog and pick up individual users or groups to be added to the review. This works as expected.

      But if the project has restriction of users/groups allowed, it behaves wrongly.
      1. if users with given prefix are found as allowed reviewers (either allowed users or members of allowed groups), only those users are listed in the Reviewers input. This seems fine
      2. but if such users are found, the Reviewers input shows all group and users with the given prefix, regardless whether they are allowed as reviewers or not on this project. It is most likely possible to add those users as reviewers to review, regardless of the allowed reviewers restrictions.

            [CRUC-7108] adding reviewers group conflicts with allowed groups

            Solved by CRUC-7676

            Adam Borowski (Inactive) added a comment - Solved by CRUC-7676

            Adam Borowski (Inactive) added a comment - I think this will be fixed automatically after fixing https://jira.atlassian.com/browse/CRUC-7717?focusedCommentId=906584&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-906584

            John Radke added a comment -

            I think the bug description is misleading, or perhaps there's additional related bug. We're on 3.6.3, have no group/user restrictions (I think--see below) and even local Crucible groups disappear once you start typing.

            I'm not sure exactly what is meant by "project group/user restrictions", but under Default Reviewers we have "By default, allow anyone to join reviews" checked and both Users and Groups are blank. Under "Allowed review participants", both Users and Groups are blank. The Permissions Scheme we have associated has no specific users or groups associated to any permissions.

            John Radke added a comment - I think the bug description is misleading, or perhaps there's additional related bug. We're on 3.6.3, have no group/user restrictions (I think--see below) and even local Crucible groups disappear once you start typing. I'm not sure exactly what is meant by "project group/user restrictions", but under Default Reviewers we have "By default, allow anyone to join reviews" checked and both Users and Groups are blank. Under "Allowed review participants", both Users and Groups are blank. The Permissions Scheme we have associated has no specific users or groups associated to any permissions.

            Jeff Louwerse added a comment - - edited

            Unless I am misinterpreting what "project group/user restrictions" refer to have this issue even with no project group/user restrictions. I tried on 3.6 and 3.7. Yes I can see the groups in the drop down IF they are in the top of the list sorted alphabetically.. however once I start typing they disappear.

            So some more digging it turns out that this will work for local crucible groups but not groups synced from Jira. That was when I also noticed that group in Crucible can't have spaces, Groups in Jira can. Since the group manager in crucible is almost unusable unless you have 10 users and you know each user my username it would be much appreciated if this could be fixed.

            Jeff Louwerse added a comment - - edited Unless I am misinterpreting what "project group/user restrictions" refer to have this issue even with no project group/user restrictions. I tried on 3.6 and 3.7. Yes I can see the groups in the drop down IF they are in the top of the list sorted alphabetically.. however once I start typing they disappear. So some more digging it turns out that this will work for local crucible groups but not groups synced from Jira. That was when I also noticed that group in Crucible can't have spaces, Groups in Jira can. Since the group manager in crucible is almost unusable unless you have 10 users and you know each user my username it would be much appreciated if this could be fixed.

              aborowski Adam Borowski (Inactive)
              pswiecicki Piotr Swiecicki
              Affected customers:
              1 This affects my team
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: