Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-9476

Changing space logo without changing filename doesn't update image

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Medium
    • None
    • 2.6.0
    • None

    Description

      It always annoys me when I upload a new logo and nothing happens until I clear the browser cache or manually refresh the page. If I upload a new logo (often with the same name as previous logo), I still expect to see it update without clearing my cache or refreshing the page.

      Including the logo file name (eg. mylogo.png) in the URL to the space/global logo has following benefits:

      • Changes in logo are more likely to be reflected in browser without clearing cache - normally the filename will change
      • Facebook and several other online apps will automatically show a logo when you reference a URL - they grab the first "major" image on a page and they seem to need a valid filename rather than just a path in order to find the logo. Otherwise, they end up choosing emoticons and all kinds of other weird things in an attempt to display a logo for the URL. When we enter http://adaptavist.com in to Facebook, we end up with a product logo that's used half way down our home page being used as the site logo. More and more services are likely to do this automated "logo grabbing" stuff as it's really cool!
      • It's just more semantic - I always cringe when I see an image being loaded using just the path, it makes me feel much better if I see a filename (even though I know that the filename itself could be a path, etc., hehe)

      To ensure that the logo is always updated in the browser (even if a new logo of same name gets uploaded) maybe something along these lines could be used: http://jira.atlassian.com/browse/CONF-9416 – I have no idea if the CSS prefix changes whenever anything to do with space CEO changes, or if there is some other internal counter that could be used within the URL, but it would be very useful to have something like this.

      A benefit of having the URL change (specifically via inclusion of some form of counter) is that we you can safely add the far-future caching headers (eg. tell browser that the logo won't be changing for 1 year) and that'll cut out the latency of any conditional gets, etc., whilst still safe in the knowledge that as soon as the logo changes it will cause the URL to change which in turn will immediately cause the browser to pull the new logo

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              gfraser@adaptavist.com Guy Fraser [Adaptavist.com]
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: