-
Suggestion
-
Resolution: Fixed
Our pull request git work flow goes like this:
A developer performs work in a feature branch, and once complete, creates a pull request in order to get it merged into master. The rest of the team (~4 members) all take part in a code review. One member of the team (and not the author) is designated as the primary reviewer. This person's job is to ensure that the points raised in the review really do get fixed before the code is merged.
It would assist our workflow if Stash allowed reviewers to indicate that they had finished the code review, even if they haven't approved it. Really they're saying they've finished one pass through the code. They may be withholding their approval because of issues they've raised, but they won't be making any more comments until the fixes are committed.
This helps the author by letting him know that the reviewers have looked at the code and have finished with their appraisal - letting the author make changes knowing that no further comments are likely to come in offering a counter-opinion.
This helps the primary reviewer to know that his colleagues have completed the review, but are withholding their approval until some issues are fixed.
- is duplicated by
-
BSERV-4633 Pull request - Approve - Decline - Reopen
- Closed
-
BSERV-4860 View a list of your pull requests
- Closed
-
BSERV-5026 Start and stop a review sessions so that the requester can be notified when I complete my review
- Closed
-
BSERV-5111 Pull Request needs a "Rework" status
- Closed
-
BSERV-5175 Enterprise code review capability in Stash
- Closed
-
BSERV-6822 Add the ability to mark reviews as "read"/"done"
- Closed
-
BSERV-6906 Add option to make Decline non-global
- Closed
-
BSERV-7353 Disapprove pull request
- Closed
-
BSERV-8308 Introduce a new button on the Pull Request page
- Closed
-
BSERV-8207 A way to identify updated pull requests (from the user's perspective) on the pull request list page
- Gathering Interest
- is related to
-
BSERV-4312 Add review state
- Gathering Interest
- relates to
-
BSERV-4120 Add type modifier to pull requests
- Closed
-
BSERV-4650 Decouple inbox from PR approval state
- Closed
- mentioned in
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...
-
Page Loading...