Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-7320

Quiet Period should not block manual builds

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • 6.2.2
    • 2.4, 2.6.2
    • Builds

      I've noticed that manually triggering the JST-BAMLESSTRUNK on StAC seems to hang for a long time before starting. I took a thread dump and noticed this:

      @400000004ce07e2a2358ed64 "ajp-j2ee.instance.jirastudio.com-bamboo%2F127.0.0.105-8009-5" daemon prio=10 tid=0x0ab45400 nid=0x507a waiting on condition [0x7ecd2000]
@400000004ce07e2a23592fcc    java.lang.Thread.State: TIMED_WAITING (sleeping)
@400000004ce07e2a235933b4       at java.lang.Thread.sleep(Native Method)
@400000004ce07e2a235952f4       at com.atlassian.bamboo.v2.trigger.DefaultChangeDetectionManager.collectChangesSinceLastBuild(DefaultChangeDetectionManager.java:77)
@400000004ce07e2a23597a04       at com.atlassian.bamboo.v2.trigger.ManualBuildDetectionAction.process(ManualBuildDetectionAction.java:73)
@400000004ce07e2a23599d2c       at com.atlassian.bamboo.build.DefaultBuildExecutionManager.tryToDetectAndBuild(DefaultBuildExecutionManager.java:130)
@400000004ce07e2a2359c054       at com.atlassian.bamboo.build.DefaultBuildExecutionManager.startManualBuild(DefaultBuildExecutionManager.java:238)
@400000004ce07e2a235a125c       at com.atlassian.bamboo.v2.ww2.build.TriggerManualBuild.doExecute(TriggerManualBuild.java:38)
@400000004ce07e2a235a3d54       at com.atlassian.bamboo.ww2.BambooActionSupport.execute(BambooActionSupport.java:804)

      This build is set to a 10 minute quiet period. It seems like manual builds should maybe ignore the quiet period. At the very least, it shouldn't block the HTTP request thread.

            [BAM-7320] Quiet Period should not block manual builds

            Don Willis added a comment -

            The implementation of quiet period is for the plan execution thread doing the change detection to sleep for the whole quiet period. This ok-ish if the quiet period is a few seconds and totally not ok if the quiet period is minutes and the server is anything but very quiet. By default there are only 4 of these threads, although the number can be increased using the "bamboo.plan.exe.threads" system property.

            Don Willis added a comment - The implementation of quiet period is for the plan execution thread doing the change detection to sleep for the whole quiet period . This ok-ish if the quiet period is a few seconds and totally not ok if the quiet period is minutes and the server is anything but very quiet. By default there are only 4 of these threads, although the number can be increased using the "bamboo.plan.exe.threads" system property.

            Tim Moore [Atlassian] added a comment -

            This build is at: https://studio.atlassian.com/builds/browse/JST-BAMLESSTRUNK

            Tim Moore [Atlassian] added a comment - This build is at: https://studio.atlassian.com/builds/browse/JST-BAMLESSTRUNK

              mgardias Marcin Gardias
              tmoore Tim Moore [Atlassian]
              Affected customers:
              8 This affects my team
              Watchers:
              10 Start watching this issue

                Created:
                Updated:
                Resolved: