• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • 1.8.1
    • 1.8.0.2
    • None
    • None
    • Mac OS X Mavericks
      Happens with either embedded Git 1.8.4.2 or system Git 1.8.5

      Steps to reproduce:

      1. Clone this repository in SourceTree: https://bitbucket.org/jennings/sourcetree-subtree-does-not-link-on-first-try
      2. Click Repository --> Add/Link Subtree
      3. Provide a remote URL and branch, and use "sub" as the local relative path. Click OK, then click Create Link.

      Expected Result:

      The subtree should now be visible in the left column under the heading "Subtrees"

      Actual Result:

      The subtree does not appear (the heading is not collapsed). If I quit SourceTree, then immediately repeat steps 2 and 3, the subtree does appear in the left column.

      I did a diff of the .git/sourcetreeconfig file between each step, and it does not have the subtree's information written into it until after quitting SourceTree and immediately trying to link the subtree again.

          Form Name

            [SRCTREE-1998] Subtree will not link on the first try

            KieranA added a comment -

            Fixed for either 1.8.0.4 or 1.8.1. Tested this thoroughly to make sure all combinations work this time and are persisted.

            Thanks for clarifying the problem further, it seems there were a few combinations which could cause this issue.

            Cheers

            KieranA added a comment - Fixed for either 1.8.0.4 or 1.8.1. Tested this thoroughly to make sure all combinations work this time and are persisted. Thanks for clarifying the problem further, it seems there were a few combinations which could cause this issue. Cheers

            KieranA added a comment -

            Hey Stephen,

            Yeah we've just confirmed this. This happens against a newly created repository which is why we haven't had it reported yet. There was another case where it wouldn't persist a link on the first try either which is what I thought you were referring to.

            If you close and re-open ST once you've created that repository you'll find you can add a subtree fine.

            Cheers

            KieranA added a comment - Hey Stephen, Yeah we've just confirmed this. This happens against a newly created repository which is why we haven't had it reported yet. There was another case where it wouldn't persist a link on the first try either which is what I thought you were referring to. If you close and re-open ST once you've created that repository you'll find you can add a subtree fine. Cheers

            jennings added a comment -

            Unfortunately I don't believe this is resolved in version 1.8.0.3 even though the release notes say it should be. I'm still able to replicate using the following steps:

            1. Quit SourceTree
            2. Open SourceTree
            3. Clone this repository: https://bitbucket.org/jennings/sourcetree-subtree-does-not-link-on-first-try
            4. Open the newly-cloned repository and use "Add/Link Subtree"
            5. Enter the remote URL, branch, and "sub" as the relative path. Click OK.

            At this point, the subtree does not appear in the left navigation bar.

            On my system (OS X Mavericks), once I clone a repository, I have to quit SourceTree first before adding a subtree link will work. If I try to add the link after cloning without relaunching in-between, it fails to add the link every time.

            jennings added a comment - Unfortunately I don't believe this is resolved in version 1.8.0.3 even though the release notes say it should be. I'm still able to replicate using the following steps: 1. Quit SourceTree 2. Open SourceTree 3. Clone this repository: https://bitbucket.org/jennings/sourcetree-subtree-does-not-link-on-first-try 4. Open the newly-cloned repository and use "Add/Link Subtree" 5. Enter the remote URL, branch, and "sub" as the relative path. Click OK. At this point, the subtree does not appear in the left navigation bar. On my system (OS X Mavericks), once I clone a repository, I have to quit SourceTree first before adding a subtree link will work. If I try to add the link after cloning without relaunching in-between, it fails to add the link every time.

            jennings added a comment -

            Much appreciated!

            jennings added a comment - Much appreciated!

            KieranA added a comment -

            Thanks for the detailed report with reproduction case. Looks like it wasn't persisting the configuration correctly. The fix will work as expected - the good news is in the meantime you can just link your subtree which will just save the 'link' to the config and not call Git at all.

            I'll get this out in the next version which should be soon.

            Thanks again

            KieranA added a comment - Thanks for the detailed report with reproduction case. Looks like it wasn't persisting the configuration correctly. The fix will work as expected - the good news is in the meantime you can just link your subtree which will just save the 'link' to the config and not call Git at all. I'll get this out in the next version which should be soon. Thanks again

              Unassigned Unassigned
              e74945cc5897 jennings
              Affected customers:
              0 This affects my team
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: