• Type: Bug
• Resolution: Fixed
• Priority: Low (View bug fix roadmap)
• Fix Version/s: 8.1.0
• Affects Version/s: 7.2.8, 7.2.12, 7.6.8, 7.12.2
• Component/s: REST API
• Labels:

  • l1l2
  • performance
  • performance-scalability
  • pse-request
  • triaged

[JSWSERVER-19230] REST call lastVisited executes board-scope-filter which leads to performance overhead

Agata Kowal made changes - 01/Jun/2023 3:58 PM

Remote Link

New: This issue links to "Page (Confluence)" [ 771485 ]

Tony D. made changes - 13/May/2020 9:30 PM

Remote Link

New: This issue links to "Page (Confluence)" [ 483883 ]

Kevin Allen made changes - 17/Apr/2020 8:30 PM

Remote Link

New: This issue links to "Page (Confluence)" [ 479634 ]

Kevin Allen made changes - 10/Apr/2020 8:00 PM

Remote Link

New: This issue links to "Page (Confluence)" [ 478597 ]

ferrari made changes - 06/Mar/2020 4:33 PM

Remote Link

New: This issue links to "Page (Confluence)" [ 474207 ]

Kasia Derenda made changes - 08/Nov/2019 9:38 AM

Remote Link

New: This issue links to "Page (Confluence)" [ 458409 ]

Clement made changes - 30/Jul/2019 5:49 AM

Remote Link

New: This issue links to "Page (Confluence)" [ 439722 ]

Andriy Yakovlev [Atlassian] made changes - 22/Jul/2019 4:54 PM

Remote Link

New: This issue links to "Page (Confluence)" [ 438326 ]

Andriy Yakovlev [Atlassian] made changes - 18/Jul/2019 4:01 PM

Description

Original: h3. Summary REST API call _PUT_ {{/rest/projects/1.0/project/<PRJ>/lastVisited}} is used to track last visited project. While executing the call, method started to load the context thus executing {{com.atlassian.greenhopper.web.sidebar.BoardScopeFilterContextProviderImpl#getContext}} which leads to expensive computations (see JSWSERVER-16185). Due to excessive computation, it puts extra pressure for the permission cache and increases CPU usage, which may lead to degraded performance of the whole Jira instance. h3. Steps to Reproduce # Load any issue, Jira will execute _PUT_ {{/rest/projects/1.0/project/<PRJ>/lastVisited}} as part of page loading # Put a break point and collect stack-trace h3. Expected Results _getContext_ is not executed h3. Actual Results _getContext_ is executed h3. Notes Taking into account that {{/lastVisited}} is executed for each issue load, this adds extra CPU overhead for Jira. Snippet from stacktrace: {noformat} ... at com.atlassian.greenhopper.service.query.QueryServiceImpl.getProjectsForRapidView(QueryServiceImpl.java:137) at com.atlassian.greenhopper.service.query.QueryServiceImpl.getExplicitProjectsForRapidViewFilterQuery(QueryServiceImpl.java:128) at com.atlassian.greenhopper.service.rapid.ProjectRapidViewServiceImpl.findProjectsByRapidView(ProjectRapidViewServiceImpl.java:69) at com.atlassian.greenhopper.service.rapid.ProjectRapidViewServiceImpl.findRapidViewsByProject(ProjectRapidViewServiceImpl.java:51) at com.atlassian.greenhopper.web.sidebar.ProjectBoardsHelper.getProjectBoards(ProjectBoardsHelper.java:53) at com.atlassian.greenhopper.web.sidebar.BoardScopeFilterContextProviderImpl.getContext(BoardScopeFilterContextProviderImpl.java:47) at com.atlassian.jira.projects.context.ProjectContextPopulatorImpl.populateWithProject(ProjectContextPopulatorImpl.java:82) at com.atlassian.jira.projects.sidebar.navigation.SidebarNavigationService.getNavigationItemById(SidebarNavigationService.java:49) at com.atlassian.jira.projects.sidebar.lastvisited.LastVisitedNavigationItemHelper.getNavigationItemById(LastVisitedNavigationItemHelper.java:58) at com.atlassian.jira.projects.sidebar.lastvisited.LastVisitedItemInProjectService.isValid(LastVisitedItemInProjectService.java:101) at com.atlassian.jira.projects.sidebar.lastvisited.LastVisitedItemInProjectService.setLastVisitedItemIdForProject(LastVisitedItemInProjectService.java:59) at com.atlassian.jira.projects.sidebar.lastvisited.LastVisitedItemResource.updateLastVisitedItem(LastVisitedItemResource.java:51) ... {noformat} h3.Workaround Please check JSWSERVER-16717 to be able to disable sidebar loading code.

New: h3. Summary REST API call _PUT_ {{/rest/projects/1.0/project/<PRJ>/lastVisited}} is used to track last visited project. While executing the call, method started to load the context thus executing {{com.atlassian.greenhopper.web.sidebar.BoardScopeFilterContextProviderImpl#getContext}} which leads to expensive computations (see JSWSERVER-16185). Due to excessive computation, it puts extra pressure for the permission cache and increases CPU usage, which may lead to degraded performance of the whole Jira instance. h3. Steps to Reproduce # Load any issue, Jira will execute _PUT_ {{/rest/projects/1.0/project/<PRJ>/lastVisited}} as part of page loading # Put a break point and collect stack-trace h3. Expected Results _getContext_ is not executed h3. Actual Results _getContext_ is executed h3. Notes Taking into account that {{/lastVisited}} is executed for each issue load, this adds extra CPU overhead for Jira. Snippet from stacktrace: {noformat} ... at com.atlassian.greenhopper.service.query.QueryServiceImpl.getProjectsForRapidView(QueryServiceImpl.java:137) at com.atlassian.greenhopper.service.query.QueryServiceImpl.getExplicitProjectsForRapidViewFilterQuery(QueryServiceImpl.java:128) at com.atlassian.greenhopper.service.rapid.ProjectRapidViewServiceImpl.findProjectsByRapidView(ProjectRapidViewServiceImpl.java:69) at com.atlassian.greenhopper.service.rapid.ProjectRapidViewServiceImpl.findRapidViewsByProject(ProjectRapidViewServiceImpl.java:51) at com.atlassian.greenhopper.web.sidebar.ProjectBoardsHelper.getProjectBoards(ProjectBoardsHelper.java:53) at com.atlassian.greenhopper.web.sidebar.BoardScopeFilterContextProviderImpl.getContext(BoardScopeFilterContextProviderImpl.java:47) at com.atlassian.jira.projects.context.ProjectContextPopulatorImpl.populateWithProject(ProjectContextPopulatorImpl.java:82) at com.atlassian.jira.projects.sidebar.navigation.SidebarNavigationService.getNavigationItemById(SidebarNavigationService.java:49) at com.atlassian.jira.projects.sidebar.lastvisited.LastVisitedNavigationItemHelper.getNavigationItemById(LastVisitedNavigationItemHelper.java:58) at com.atlassian.jira.projects.sidebar.lastvisited.LastVisitedItemInProjectService.isValid(LastVisitedItemInProjectService.java:101) at com.atlassian.jira.projects.sidebar.lastvisited.LastVisitedItemInProjectService.setLastVisitedItemIdForProject(LastVisitedItemInProjectService.java:59) at com.atlassian.jira.projects.sidebar.lastvisited.LastVisitedItemResource.updateLastVisitedItem(LastVisitedItemResource.java:51) ... {noformat} Based on performance data, {{/lastVisited}} calls might be up to 10% of all CPU active threads. h3.Workaround Please check JSWSERVER-16717 to be able to disable sidebar loading code.

Kamil Kolonko made changes - 04/Apr/2019 11:56 AM

Resolution		New: Fixed [ 1 ]
Status	Original: Waiting for Release [ 12075 ]	New: Closed [ 6 ]

Load more older history items