Issue Summary

In JSM, there is a condition called "Block transition until approval" which is used by workflow with approval status.
This condition only works for the 2 transitions which are connected to the status with approval, but it has absolutely no effect if it is added to any other transition in the workflow.

Steps to Reproduce

• Create a fresh JSM project
• Take a look at the workflow named as "Case Workflow", and notice that:
  • the status "Awaiting Approval" is configured by default with an Approval
  • 

• the "Select transition if approved" setting is mapped to the transition "Approved", and the "Select transition if declined" setting is mapped to the transition "Declined"
• the "Declined" and "Approved" transitions are automatically configured with the condition "Block transition until approval" (="Issue transition will be blocked if there is a pending approval):
• 
• Edit this workflow by adding the condition "Block transition until approval" to the transition "Close as not approved" which is connected from the status "Declined" to the status "Closed"
• Publish the workflow
• Create a new request using this workflow
• Open the request by being logged in as a User
• Check that:
  • the request is in the status "Awaiting Approval"
  • the 2 transitions used in the approval configuration "Approved" and "Declined" are blocked as expected, since they can only be executed by the approver
  • however, the "Close as not approved" transition is still available and working, despite the condition "Block transition until approval"
  • 

Suggested solution:

It has been confirmed that this current behaviour is intended by design (according to how the code was implemented), and is due to some workflow limitation.
However, this behavior is not ideal and is confusing, since the workflow allows us to add the condition "Block transition until approval" to any transition, even though it has no effect.

2 possible solution to this problem:

• either make this condition effective when it's added to any transition in the workflow
• or don't allow this condition to be added to any transition, since it has no effect anyway