cluster.properties does not trim trailing white space in paths

Problem

When defining the paths in cluster.properties, JIRA does not trim trailing spaces when reading. This can result in confusion as the paths look correct, but JIRA is not able to access existing applications, index snapshots, etc.

• Note that this differs from other files like the jira-application.properties, where JIRA does trim trailing spaces

Steps to Reproduce

• Setup JIRA Data Center with 2 nodes
• For one node, modifying the cluster.properties, add an extra space at the end of the path for jira.shared.home
• Save, complete JDC setup
• Add attachments to node 1
• Now access node 2 and notice that the attachment is unavailable.

Expected Behaviour

Similar to the jira-application.properties, JIRA should trim trailing white spaces

Actual Results

Nodes are using different shared home paths, thus they are unable to access data from the shared home that other nodes have stored.

• You'll also notice the extra space in startup following in startup:

           Attachment Path                               : /Users/dchan/atlassian/jira728dc/shared-home /data/attachments
  

Other notes

You'll also see multiple shared home folders:

$ ll
total 518912
drwxr-xr-x   7 dchan  staff   238B Oct  5 09:36 .
drwxr-xr-x  66 dchan  staff   2.2K Oct  4 07:58 ..
-rw-r--r--@  1 dchan  staff   253M May 10 09:39 atlassian-jira-software-7.2.8.tar.gz
drwxr-xr-x@ 17 dchan  staff   578B May 10 09:40 jira728node1
drwxr-xr-x@ 19 dchan  staff   646B May 10 10:24 jira728node2
drwxr-xr-x  10 dchan  staff   340B Aug 31 10:20 shared-home
drwxr-xr-x   9 dchan  staff   306B Oct  5 09:38 shared-home
jira728dc$ cd shared-home
shared-home/  shared-home /

Workaround

Check config file and delete spaces