Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-39319

Try to remove SearchContext usages on the SearchInputTransformer hierarchy

    XMLWordPrintable

Details

    • Severity 3 - Minor
    • Hide

      Atlassian Update – 04 July 2019

      Hi everyone,

      After reviewing the overall customer interest and impact of this bug report we have decided to close this issue down. Our analysis has shown that over time this issue hasn't collected a significant number of votes, watchers, comments, or support cases from customers and therefore has remained very low on our priority list. Given these findings we can conclude it will not be fixed in the foreseeable future and wish to be transparent about our priorities by closing it as Timed Out.

      Although we're aware this issue may be still important to those of you who were involved in the initial conversations around it, we want to be clear by managing your expectations regarding the likelihood of a fix for it. The Jira team do their best to prioritise the issues that have high and critical impact with broad pervasiveness reflected in series of different factors. You can learn more about this by reading our Bug Fixing Policy.

      To see what the Jira team is currently working on and has recently delivered see the following dashboards:

      We understand that hearing a decision like this can be disappointing, but we hope you'll appreciate our transparent approach to product priorities and communications. We will continue to watch this issue for further updates, so please feel free to share any thoughts in the comments.

      Thank you,

      Pawel Drygas,

      Jira Server Bugmaster

      Show
      Atlassian Update – 04 July 2019 Hi everyone, After reviewing the overall customer interest and impact of this bug report we have decided to close this issue down. Our analysis has shown that over time this issue hasn't collected a significant number of votes, watchers, comments, or support cases from customers and therefore has remained very low on our priority list. Given these findings we can conclude it will not be fixed in the foreseeable future and wish to be transparent about our priorities by closing it as Timed Out . Although we're aware this issue may be still important to those of you who were involved in the initial conversations around it, we want to be clear by managing your expectations regarding the likelihood of a fix for it. The Jira team do their best to prioritise the issues that have high and critical impact with broad pervasiveness reflected in series of different factors. You can learn more about this by reading our Bug Fixing Policy . To see what the Jira team is currently working on and has recently delivered see the following dashboards: Jira Server and Data Center: Recently resolved issues Jira Server and Data Center: Current work and future plans Jira Server and Data Center: Bug Fix Board We understand that hearing a decision like this can be disappointing, but we hope you'll appreciate our transparent approach to product priorities and communications. We will continue to watch this issue for further updates, so please feel free to share any thoughts in the comments. Thank you, Pawel Drygas, Jira Server Bugmaster

    Description

      NOTE: This bug report is for JIRA Server. Using JIRA Cloud? See the corresponding bug report.

      The SearchInputTransformer interface has three methods receiving a SearchContext:

      • void validateParams(User user, SearchContext searchContext, FieldValuesHolder fieldValuesHolder, I18nHelper i18nHelper, ErrorCollection errors);
      • void populateFromQuery(User user, FieldValuesHolder fieldValuesHolder, Query query, final SearchContext searchContext);
      • boolean doRelevantClausesFitFilterForm(User user, Query query, SearchContext searchContext);

      That interface is being implemented by ~30 classes, and only a few of them are actually using the SearchContext on those methods.

      We need to investigate if those usages are actually needed or if we can get rid of the SearchContext in this whole hierarchy.

      The classes that we need to further investigate are CascadingSelectCustomFieldSearchInputTransformer, SelectCustomFieldSearchInputTransformer and AbstractCustomFieldSearchInputTransformer.

      For the implementations of those methods on those classes it is not very obvious if the usages of the SearchContext are really needed (from an behavioural point of view)

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              jsanchez@atlassian.com Jose Jaime Sanchez (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: