Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-3625

CVS Add Repository Fails when a line of repeated "=" is found in cvs logs

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 3.0 Pro Preview
    • 2.6.1 Pro
    • None
    • Jira 2.6.1 Pro w/bundled Tomcat on Solaris 9, java version "1.4.2_04"
      Java(TM) 2 Runtime Environment, Standard Edition (build 1.4.2_04-b05)
      Java HotSpot(TM) Client VM (build 1.4.2_04-b05, mixed mode)

      When doing an Add CVS Repository of a repository that has a line of "=" in one of the log messages it fails with a Null Pointer Exception.

      May be related to JRA-3492

      Log message suspected of causing error (see further below for trace):

      [dnichols@tricorder solomon]$ cvs log file4

      RCS file: /src/solomon/file4,v
      Working file: file4
      head: 1.2
      branch:
      locks: strict
      access list:
      symbolic names:
      Initial: 1.1.1.1
      Neutral: 1.1.1
      keyword substitution: kv
      total revisions: 3; selected revisions: 3
      description:
      ----------------------------
      revision 1.2
      date: 2004/04/21 19:56:42; author: dnichols; state: Exp; lines: +0 -3
      This is to test Jira CVS Log import.
      See if the line below causes an error
      ================================================================
      ----------------------------
      revision 1.1
      date: 2004/04/21 18:54:05; author: dnichols; state: Exp;
      branches: 1.1.1;
      Initial revision
      ----------------------------
      revision 1.1.1.1
      date: 2004/04/21 18:54:05; author: dnichols; state: Exp; lines: +0 -0
      Initial Import – starting fresh for Jira testing
      =============================================================================
      [dnichols@tricorder solomon]$

      catalina.out:
      2004-04-21 16:00:57,406 ERROR [action.admin.vcs.AddRepository] Error occurred while updating the cvs repository, obtaining cvs log or parsing the cvs log.
      java.lang.NullPointerException
      at org.netbeans.lib.cvsclient.command.log.LogBuilder.processRevisionStart(LogBuilder.java:266)
      at org.netbeans.lib.cvsclient.command.log.LogBuilder.parseLine(LogBuilder.java:131)
      at com.atlassian.jira.vcs.cvsimpl.CvsRepositoryUtilImpl$1.parseLine(CvsRepositoryUtilImpl.java:92)
      at org.netbeans.lib.cvsclient.command.BuildableCommand.messageSent(BuildableCommand.java:94)
      at org.netbeans.lib.cvsclient.event.MessageEvent.fireEvent(MessageEvent.java:96)
      at org.netbeans.lib.cvsclient.event.EventManager.fireCVSEvent(EventManager.java:107)
      at org.netbeans.lib.cvsclient.response.MessageResponse.process(MessageResponse.java:52)
      at org.netbeans.lib.cvsclient.Client.handleResponse(Client.java:444)
      at org.netbeans.lib.cvsclient.Client.processRequests(Client.java:405)
      at org.netbeans.lib.cvsclient.command.log.LogCommand.execute(LogCommand.java:132)
      at org.netbeans.lib.cvsclient.Client.executeCommand(Client.java:488)
      at com.atlassian.jira.vcs.cvsimpl.CvsRepositoryUtilImpl.updateCvs(CvsRepositoryUtilImpl.java:104)
      at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.testRepository(RepositoryActionSupport.java:213)
      at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.checkRepository(RepositoryActionSupport.java:182)
      at com.atlassian.jira.web.action.admin.vcs.AddRepository.doValidation(AddRepository.java:58)
      at webwork.action.ActionSupport.validate(ActionSupport.java:371)
      at webwork.action.ActionSupport.execute(ActionSupport.java:148)
      at com.atlassian.jira.action.JiraActionSupport.execute(JiraActionSupport.java:49)
      at webwork.dispatcher.GenericDispatcher.executeAction(GenericDispatcher.java:131)
      at com.atlassian.jira.web.dispatcher.JiraServletDispatcher.service(JiraServletDispatcher.java:186)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:247)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
      at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:129)
      at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:61)
      at com.atlassian.jira.web.filters.SitemeshExcludePathFilter.doFilter(SitemeshExcludePathFilter.java:36)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:213)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
      at com.atlassian.seraph.filter.SecurityFilter.doFilter(SecurityFilter.java:164)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:213)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
      at com.atlassian.seraph.filter.LoginFilter.doFilter(LoginFilter.java:181)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:213)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
      at com.atlassian.util.profiling.filters.ProfilingFilter.doFilter(ProfilingFilter.java:132)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:213)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
      at com.atlassian.jira.web.filters.ActionCleanupDelayFilter.doFilter(ActionCleanupDelayFilter.java:37)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:213)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
      at com.atlassian.johnson.filters.JohnsonFilter.doFilter(JohnsonFilter.java:96)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:213)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
      at com.atlassian.jira.web.filters.gzip.GzipFilter.doFilter(GzipFilter.java:60)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:213)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
      at com.atlassian.core.filters.AbstractEncodingFilter.doFilter(AbstractEncodingFilter.java:38)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:213)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:193)
      at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:256)
      at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
      at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
      at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
      at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
      at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
      at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
      at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
      at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:2417)
      at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:180)
      at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
      at org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatcherValve.java:171)
      at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
      at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:172)
      at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:641)
      at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
      at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
      at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:174)
      at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:643)
      at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:480)
      at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)
      at org.apache.coyote.tomcat4.CoyoteAdapter.service(CoyoteAdapter.java:193)
      at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:781)
      at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:549)
      at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:589)
      at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:666)
      at java.lang.Thread.run(Thread.java:534)

            anton@atlassian.com AntonA
            107a466fe287 David Nichols
            Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: