Uploaded image for project: 'Jira Cloud'
  1. Jira Cloud
  2. JRACLOUD-60833

validateTransition in IssueService API does not allow for validation of actions(transitions) with no view(screen) attached

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Fix
    • Low
    • None
    • None

    Description

      NOTE: This bug report is for JIRA Cloud. Using JIRA Server? See the corresponding bug report.

      Problem Definition

      1. Currently the service only validates and updates fields if a view is associated with the action.

              if (StringUtils.isNotEmpty(actionDescriptor.getView())) {
                  updatedIssue = validateAndUpdateIssueFromFields(user, issue, issueInputParameters, fieldValuesHolder,
                          errors, i18n, getTransitionFieldScreenRenderer(issue, actionDescriptor), false, actionId);
      
                  if (errors.hasAnyErrors()) {
                      return new TransitionValidationResult(null, errors, fieldValuesHolder, null, actionId);
                  }
                  // Comment information is handled by the generated change history so no need to put it into the additional
                  // parameters
              } else {
                  updatedIssue = issue;
              }
      

      2. Furthermore validateAndUpdateIssueFromFields takes in a boolean updateComment which determines whether or not to update the comment, however if this is set to false and skipScreenCheck is set to true in the IssueInputParameters then the comment is updated regardless.

      Proposed Solution

      1. An OR condition be added to the if statement which determines if we care about a screen attached
      ie. We want to be able to validate and update fields without a screen

      2. updateIssueFromFieldsWithoutScreenCheck should either
      A. check for the updateComment boolean
      OR
      B. not update the comment orderableField

      Attachments

        Issue Links

          Activity

            People

              jthai Jason T
              jthai Jason T
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: