Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-60833

validateTransition in IssueService API does not allow for validation of actions(transitions) with no view(screen) attached

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Low
    • None
    • None
    • None
    • None
    • 1
    • Severity 3 - Minor
    • 1
    • Hide
      Atlassian Update – 22 October 2018

      Hi everyone,

      We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future, i.e. in next 6 months.

      Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Jira team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Atlassian Bugfix Policy for more details.

      We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication.

      Atlassian will keep the issue open and continue to watch this issue for the further updates.

      Thank you,
      Ignat Alexeyenko
      Jira Bugmaster

      Show
      Atlassian Update – 22 October 2018 Hi everyone, We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future, i.e. in next 6 months. Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Jira team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Atlassian Bugfix Policy for more details. We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will keep the issue open and continue to watch this issue for the further updates. Thank you, Ignat Alexeyenko Jira Bugmaster

    Description

      NOTE: This bug report is for JIRA Server. Using JIRA Cloud? See the corresponding bug report.

      Problem Definition

      1. Currently the service only validates and updates fields if a view is associated with the action.

              if (StringUtils.isNotEmpty(actionDescriptor.getView())) {
            updatedIssue = validateAndUpdateIssueFromFields(user, issue, issueInputParameters, fieldValuesHolder,
                    errors, i18n, getTransitionFieldScreenRenderer(issue, actionDescriptor), false, actionId);

            if (errors.hasAnyErrors()) {
                return new TransitionValidationResult(null, errors, fieldValuesHolder, null, actionId);
            }
            // Comment information is handled by the generated change history so no need to put it into the additional
            // parameters
        } else {
            updatedIssue = issue;
        }

      2. Furthermore validateAndUpdateIssueFromFields takes in a boolean updateComment which determines whether or not to update the comment, however if this is set to false and skipScreenCheck is set to true in the IssueInputParameters then the comment is updated regardless.

      Proposed Solution

      1. An OR condition be added to the if statement which determines if we care about a screen attached
      ie. We want to be able to validate and update fields without a screen

      2. updateIssueFromFieldsWithoutScreenCheck should either
      A. check for the updateComment boolean
      OR
      B. not update the comment orderableField

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JRASERVER-23814 Unexpected behaviour with IssueInputParameters.setComment()

          • Low - Low priority issues
          • Gathering Impact
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JRACLOUD-60833 validateTransition in IssueService API does not allow for validation of actions(transitions) with no view(screen) attached

          • Low - Low priority issues
          • Closed

          Activity

            People

              Unassigned Unassigned
              jthai Jason T
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: