[JIRAALIGN-1549] Personas page can throw a 500 error with Feature Toggle 45 enabled

Issue Summary

When navigating to the Personas page in Jira Align a 500 error can be thrown if feature toggle 45 is enabled. This is because the persona file name somehow is not what we expected and, when we split it, the second index(idAdnExtension) is actually null or out of range.

This can be reproduced on sabenw.agilecraft.com. This toggle has been disabled for now, but, the issue can easily be reproduced if the toggle is reenabled.

Steps to Reproduce

1. Log in to the instance and make sure the feature toggle 45 is enabled
2. Navigate to the Personas page

Expected Results

Personas page loads

Actual Results

500 internal server error

The below exception is thrown in splunk

 ASP_function: Error.asp
   ErrorId: 8
   PageName: Personas
   correlationid: GaLkjYrTsP3/P9mOpAQoTrmUtYDjNcS+solYalFYNm0=
   customer_db: Cprime2
   error_aspcode:
   error_aspdescription:
   error_category: Microsoft VBScript runtime 
   error_column: -1
   error_description: Subscript out of range: '[number: 1]'
   error_file: /OOFunctionsFileSystem.asp
   error_line: 139
   error_number: -2146828279
   error_source:
   log_type: exception
   logfrom_location: Website-ASP
   timestamp: 2020-05-26T04:24:10.867000-04:00
   url: https://sabenw.agilecraft.com:443/Personas.asp?FirstTime=true
   urlverb: GET
   user: Mark.Amodei
   version:  10.73.0.5119

Function WriteImageTagPersona(personaFileName, imgTagType)
    Dim u_file

    If (CheckFeatureById(c_FeatureToggle_FileAttachmentDatabase)) Then
        Dim personaId

        If IsNothing(personaFileName) then 
            personaId="\"
        Else
            nameAndId = Split(personaFileName,"_")
            idAndExtension= Split(nameAndId(1),".")
            personaId = idAndExtension(0)        
        End If

Workaround

This is a rare issue, so, please ask the Jira Align support team to temporarily disable Feature Toggle 45, which Increases performance of the DB with uploading and storing file attachments in Jira Align. This should not have a big impact on day to day operations of the application.