Uploaded image for project: 'Crowd Data Center'
  1. Crowd Data Center
  2. CWD-1860

Retrieve only the necessary attributes when searching for LDAP users and groups

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Fixed
    • 2.6
    • Directory - LDAP
    • None

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      Currently Crowd makes a query for all the attributes on a given entity: role, group or user. This results in a very large dataset being returned for all searches, regardless of purpose.

      At a minimum, we should only request attributes which are used by Crowd: the name, description and member attributes for groups and roles, and all the mapped attributes for users.

      Even better would be to retrieve only the membership attributes when searching for memberships, only the group attributes when looking up groups, and so on.

      The minimum requirement is quite easy to implement, and I'll attach a simple (completely untested) patch that I'd like to see tested in the future. The second option would be harder, requiring some redesign of the SpringLDAPConnector, which currently has only has one place where SearchControls objects are constructed for all LDAP searches.

        1. CONF-22326-patch.zip-4.3.2
          28 kB
        2. CWD-1860_naive_and_untested_implementation.patch
          2 kB
        3. CWD-1860_naive_and_untested_implementation.patch
          2 kB
        4. CWD-1860_naive_and_untested_implementation.patch
          2 kB

            [CWD-1860] Retrieve only the necessary attributes when searching for LDAP users and groups

            Katherine Yabut made changes -
            Workflow Original: JAC Suggestion Workflow [ 3388638 ] New: JAC Suggestion Workflow 3 [ 3630741 ]
            Status Original: RESOLVED [ 5 ] New: Closed [ 6 ]
            Monique Khairuliana (Inactive) made changes -
            Workflow Original: Simplified Crowd Development Workflow v2 [ 1392519 ] New: JAC Suggestion Workflow [ 3388638 ]
            Issue Type Original: Improvement [ 4 ] New: Suggestion [ 10000 ]
            vkharisma made changes -
            Link New: This issue relates to JRACLOUD-26434 [ JRACLOUD-26434 ]
            vkharisma made changes -
            Link New: This issue is related to CONFCLOUD-23943 [ CONFCLOUD-23943 ]
            Owen made changes -
            Workflow Original: Crowd Development Workflow v2 [ 273619 ] New: Simplified Crowd Development Workflow v2 [ 1392519 ]
            AdrienA (Inactive) made changes -
            Link New: This issue has a regression in CWD-3159 [ CWD-3159 ]

            Matt Ryall added a comment -

            Note: this patch works only for Active Directory. It has hard-coded attribute names in it that will break in unusual ways on other servers.

            Matt Ryall added a comment - Note: this patch works only for Active Directory. It has hard-coded attribute names in it that will break in unusual ways on other servers.
            Denise Unterwurzacher [Atlassian] (Inactive) made changes -
            Attachment New: CONF-22326-patch.zip-4.3.2 [ 82817 ]

            Denise Unterwurzacher [Atlassian] (Inactive) added a comment - - edited

            I have attached patch.zip-4.3.2 for versions 4.3.2 - 4.3.7 of Confluence, and any Atlassian app with version 1.5.3 of Embedded Crowd (check with Support if you're unsure). Please refer to the installation instructions on how to install this patch.

            The subdirectories for the class file are <confluence-installation-directory>/confluence/WEB-INF/classes/com/atlassian/crowd/directory. Please create these folders if they don't already exist. You need to remove the "-4.3.2" from the class file names before copying them.

            NB: This patch is not formally tested, so please ensure that you apply this to a test Confluence instance and test it thoroughly before applying it to your production Confluence.

            Denise Unterwurzacher [Atlassian] (Inactive) added a comment - - edited I have attached patch.zip-4.3.2 for versions 4.3.2 - 4.3.7 of Confluence, and any Atlassian app with version 1.5.3 of Embedded Crowd (check with Support if you're unsure). Please refer to the installation instructions on how to install this patch. The subdirectories for the class file are <confluence-installation-directory>/confluence/WEB-INF/classes/com/atlassian/crowd/directory . Please create these folders if they don't already exist. You need to remove the "-4.3.2" from the class file names before copying them. NB: This patch is not formally tested, so please ensure that you apply this to a test Confluence instance and test it thoroughly before applying it to your production Confluence.
            Tim Wong (Inactive) made changes -
            Remote Link New: This issue links to "Wiki Page (Extranet)" [ 23832 ]

              jwalton joe
              matt@atlassian.com Matt Ryall
              Votes:
              3 Vote for this issue
              Watchers:
              13 Start watching this issue

                Created:
                Updated:
                Resolved: