Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-7387

Error adding a patch ending with diffs for binary files

    XMLWordPrintable

Details

    • Bug
    • Resolution: Timed out
    • Low
    • None
    • 3.8.0
    • None

    Description

      If you try to add a patch like:

      diff --git a/src/tests/com/cenqua/fisheye/svn/BlameFallbackTest.java b/src/tests/com/cenqua/fisheye/svn/BlameFallbackTest.java
      index 3ff8f99..bec1c7d 100644
      --- a/src/tests/com/cenqua/fisheye/svn/BlameFallbackTest.java
      +++ b/src/tests/com/cenqua/fisheye/svn/BlameFallbackTest.java
      @@ -2,12 +2,8 @@ package com.cenqua.fisheye.svn;
      -import com.cenqua.fisheye.rep.BlameChunk;
      -import com.google.common.base.Objects;
      -import org.hamcrest.Description;
      -import org.hamcrest.TypeSafeMatcher;
      diff --git a/test/testfiles/git.zip
      new file mode 100644
      index 0000000..da3ad58
      Binary files /dev/null and b/test/testfiles/git.zip differ
      

      to a review, a NullPointerException will be thrown. This is caused by inproper parsing of the last file header.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              lpater Lukasz Pater
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: