Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-6114

Pre-commit review error: SVN patch containing Property changes cannot be uploaded.

    XMLWordPrintable

    Details

      Description

      We have a customer that has this patch segment in a patch file:

      Index: utf8
      ===================================================================
      --- utf8	(revision 0)
      +++ utf8	(working copy)
      
      Property changes on: utf8
      ___________________________________________________________________
      Added: bugtraq:label
      ## -0,0 +1 ##
      +Issue ID
      \ No newline at end of property
      Added: bugtraq:url
      ## -0,0 +1 ##
      +http://www.customer.com/blah/hello.php?helpid=%HELPID%
      \ No newline at end of property
      Added: bugtraq:message
      ## -0,0 +1 ##
      +Issue: %BUGID%
      \ No newline at end of property
      Added: bugtraq:warnifnoissue
      ## -0,0 +1 ##
      +true
      \ No newline at end of property
      Added: bugtraq:logregex
      ## -0,0 +1,2 ##
      +[Ii]ssues?:?(\s*(,|and)?\s*#\d+)+
      +(\d+)
      \ No newline at end of property
      

      Crucible fails to load this patch because it is not a standard hunk. JPatch fails on it too but it should give a warning instead. We should ignore/remove all of these from pre-commit patches in the short term and maybe show the permissions changes in the long term.

      This issue is exactly the same as this one: http://code.google.com/p/reviewboard/issues/detail?id=2359

      Workaround

      Using SVN 1.8+, create the diff with the --patch-compatible flag:

      svn --patch-compatible diff > patch.txt

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jbronczyk Jerzy Bronczyk [Atlassian] (Inactive)
              Reporter:
              rmassaioli Robert Massaioli
              Votes:
              63 Vote for this issue
              Watchers:
              36 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 1.7h
                  1.7h