Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-6671

Reviews with multiple revisions: added + modified files are shown in blue (modified), not green (added)

XMLWordPrintable

      If you create a review with multiple revisions, and include a file which has been added in one revision and modified in a later revision, then the file name is marked as blue (modified), not as green (added).

      It should be shown as green so that reviewers can see that this is a new file.

      Further, only the changes from the modification revision are shown, when all changes to the file ought to be shown (as described in detail on CRUC-6312)

            [CRUC-6671] Reviews with multiple revisions: added + modified files are shown in blue (modified), not green (added)

            Marek Parfianowicz made changes -
            Fix Version/s New: N/A [ 54415 ]
            Marek Parfianowicz made changes -
            Resolution New: Answered [ 9 ]
            Status Original: Long Term Backlog [ 12073 ] New: Closed [ 6 ]

            Marek Parfianowicz added a comment -
            Atlassian Update – 10 January 2022

            Hi everyone,

            We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to close it.

            We want to be clear in managing your expectations. The Fisheye & Crucible team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Atlassian Bug Fixing Policy for more details.

            If you still see this bug occurring in the latest release and a fix is very important for you, please don't hesitate to share your feedback in the issue comments and vote on it. We will continue to watch the issue for further updates.

            Kind regards
            Marek Parfianowicz
            Development Team Lead

            Marek Parfianowicz added a comment - Atlassian Update – 10 January 2022 Hi everyone, We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to close it. We want to be clear in managing your expectations. The Fisheye & Crucible team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Atlassian Bug Fixing Policy for more details. If you still see this bug occurring in the latest release and a fix is very important for you, please don't hesitate to share your feedback in the issue comments and vote on it. We will continue to watch the issue for further updates. Kind regards Marek Parfianowicz Development Team Lead
            Marek Parfianowicz made changes -
            Labels Original: review-ux New: jac-cleanup-phase9 review-ux
            SET Analytics Bot made changes -
            UIS Original: 0 New: 1
            SET Analytics Bot made changes -
            UIS Original: 1 New: 0
            Marek Parfianowicz made changes -
            Component/s New: Code reviews [ 54890 ]

            Marek Parfianowicz added a comment -

            Thank you for your hint, Alexander. We will take this into account.

            Marek Parfianowicz added a comment - Thank you for your hint, Alexander. We will take this into account.

            Alexander Taler added a comment -

            Part of this issue is also the highlighting colour of file content.

            Currently when looking at a change newly added lines are shown with a green highlight. When looking at the full file content (no change) the entire file is shown in white.

            With your proposal a newly added file would never show in green highlight, which is an inconsistency in the interface, liable to be confusing to users. The use of green at the top and left is good, but not nearly as strong a visual cue as the green highlight, and I'm pretty certain many users don't pay attention to those more minor cues, I know that they are not the first thing that I look for.

            Thanks for finally looking at this issue.

            Alexander Taler added a comment - Part of this issue is also the highlighting colour of file content. Currently when looking at a change newly added lines are shown with a green highlight. When looking at the full file content (no change) the entire file is shown in white. With your proposal a newly added file would never show in green highlight, which is an inconsistency in the interface, liable to be confusing to users. The use of green at the top and left is good, but not nearly as strong a visual cue as the green highlight, and I'm pretty certain many users don't pay attention to those more minor cues, I know that they are not the first thing that I look for. Thanks for finally looking at this issue.

            Richard Bradley added a comment -

            That is disappointing. It seems to me that this is a fairly serious failure of correctness in Crucible's core functionality, so should be fixed faster than 6 years.

            Richard Bradley added a comment - That is disappointing. It seems to me that this is a fairly serious failure of correctness in Crucible's core functionality, so should be fixed faster than 6 years.

              Unassigned Unassigned
              7f58a9b9996f Richard Bradley
              Affected customers:
              15 This affects my team
              Watchers:
              9 Start watching this issue

                Created:
                Updated:
                Resolved: