Thank you for your hint, Alexander. We will take this into account.

Part of this issue is also the highlighting colour of file content.

Currently when looking at a change newly added lines are shown with a green highlight. When looking at the full file content (no change) the entire file is shown in white.

With your proposal a newly added file would never show in green highlight, which is an inconsistency in the interface, liable to be confusing to users. The use of green at the top and left is good, but not nearly as strong a visual cue as the green highlight, and I'm pretty certain many users don't pay attention to those more minor cues, I know that they are not the first thing that I look for.

Thanks for finally looking at this issue.

That is disappointing. It seems to me that this is a fairly serious failure of correctness in Crucible's core functionality, so should be fixed faster than 6 years.

It already got the 'long term roadmap' status instead of the 'gathering impact', but to be honest we've got around 100 open bugs having higher priority than this one. Thus I cannot tell in which release it will be fixed at the moment. Definitely not in 4.7 (Feb 2019) and not in 4.8 (mid-2019).

Thanks. Will you increase the priority of this bug? In my opinion, it should be "major", not "minor", since incorrect data is shown to reviewers which can lead to code going unreviewed when it has been added to a review. (c.f. https://confluence.atlassian.com/support/atlassian-server-bug-fix-policy-201294573.html )

Hi Richard, thank you very much for your detailed scenarios. I agree. We shall not only handle first round of review (when all files have not been seen by reviewer yet), but also a case for next review iterations (with new commits added). I updated my comment. 

Marek, I don't think your proposed fix will cope correctly with all cases. Crucible currently keeps track of which revisions a reviewer has and has not seen in a review, and shows them only new revisions by default. This is a useful feature, but it is broken in the added+modified case.

I think the following user story needs fixing:

• Alice creates a review
• Alice adds commit 1 which updates file A and adds file B
• Alice adds commit 2 which updates file A and updates file B
• Alice adds Bob as a reviewer
• Bob visits the review, selects file A

• • He is shown the changes from commit 1 and commit 2
• Bob visits the review, selects file B
  • He should be shown the changes from commit 1 and commit 2
  • Currently he is shown only the changes from commit 2 – this is a bug
• Alice adds commit 3 which updates file A and updates file B
• Bob visits the review, selects file A
  • He is shown the changes from commit 3
• Bob visits the review, selects file A
  • He should be shown the changes from commit 3
  • Currently he is shown he changes from commit 3
  • I believe your proposed fix would show him the whole file

Proposed solution:

If file in a review has been added+modified, then:

• colour it in green in file tree (i.e. as added)
• in file view panel use "added" label (alternatively: "added&modified")
• scroll slider to show not a diff but the latest revision (i.e. content of the entire file)
  • unless previously added commits have been already reviewed - in such case show a diff between last seen and most recent commit

This is STILL happening for me, on current Crucible, and still causing reviewers to miss changes and waste time