-
Suggestion
-
Resolution: Unresolved
-
None
-
3
-
Currently, Crucible uses table based rendering, which could potentially blow out the DOM with large reviews (i.e., greater than 1000~ lines of diffs).
The solution is to progressively render each line of diff, so that there isn't so many dom elements. This has been implemented in Fisheye's side-by-side view, and should be used in crucible.
The problem may be in how we might have to render comments associated with the diff. Not sure how that can be solved yet.
- mentioned in
-
Wiki Page Failed to load
[CRUC-4184] Make Crucible reviews use progressive rendering of diffs
Workflow | Original: JAC Suggestion Workflow [ 3020619 ] | New: JAC Suggestion Workflow 3 [ 3633046 ] |
Status | Original: Reviewing [ 11773 ] | New: Not Being Considered [ 11776 ] |
UIS | New: 3 |
Workflow | Original: Confluence Workflow - Public Facing v4 [ 2948020 ] | New: JAC Suggestion Workflow [ 3020619 ] |
Status | Original: Gathering Interest [ 11772 ] | New: Reviewing [ 11773 ] |
Workflow | Original: FECRU Development Workflow - Triage [ 940379 ] | New: Confluence Workflow - Public Facing v4 [ 2948020 ] |
Status | Original: Open [ 1 ] | New: Gathering Interest [ 11772 ] |
Backlog Order (Obsolete) | Original: 3240000000 | |
Issue Type | Original: Improvement [ 4 ] | New: Suggestion [ 10000 ] |
Workflow | Original: FECRU Development Workflow (Triage) [ 315662 ] | New: FECRU Development Workflow - Triage [ 940379 ] |
Labels | New: diff review-ux |
Remote Link | New: This issue links to "Wiki Page (Extranet)" [ 23520 ] |