Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-4184

Make Crucible reviews use progressive rendering of diffs

    • 3
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      Currently, Crucible uses table based rendering, which could potentially blow out the DOM with large reviews (i.e., greater than 1000~ lines of diffs).

      The solution is to progressively render each line of diff, so that there isn't so many dom elements. This has been implemented in Fisheye's side-by-side view, and should be used in crucible.

      The problem may be in how we might have to render comments associated with the diff. Not sure how that can be solved yet.

            [CRUC-4184] Make Crucible reviews use progressive rendering of diffs

            Atlassian Update – 19 August 2019

            Hi everyone,

            We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Not being considered.

            Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Fisheye&Crucible team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Implementation of New Features Policy for more details.

            We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments.

            Regards
            Marek Parfianowicz
            Development Team Lead
            Fisheye/Crucible Team

            Marek Parfianowicz added a comment - Atlassian Update – 19 August 2019 Hi everyone, We have recently reviewed this issue and the overall interest in the problem. As the issue hasn't collect votes, watchers, comments, or support cases from many customers during its lifetime, it's very low on our priority list, and will not be fixed in the foreseeable future. That's why we've decided to resolve it as Not being considered . Although we're aware the issue is still important to those of you who were involved in the conversations around it, we want to be clear in managing your expectations. The Fisheye&Crucible team is focusing on issues that have broad impact and high value, reflected by the number of comments, votes, support cases, and customers interested. Please consult the Implementation of New Features Policy for more details. We understand how disappointing this decision may be, but we hope you'll appreciate our transparent approach and communication. Atlassian will continue to watch this issue for further updates, so please feel free to share your thoughts in the comments. Regards Marek Parfianowicz Development Team Lead Fisheye/Crucible Team

            Hi David,
            I'm afraid this issue was not yet addressed. In 3.6 we have made few changes on the backend side to ensure review and changeset pages load faster, but we didn't manage to refactor review page to render diffs progressively I am afraid. Keep watching this issue please, so you will get notified when we manage to address this particular issue.
            Hope that helps,
            Piotr

            Piotr Swiecicki added a comment - Hi David, I'm afraid this issue was not yet addressed. In 3.6 we have made few changes on the backend side to ensure review and changeset pages load faster, but we didn't manage to refactor review page to render diffs progressively I am afraid. Keep watching this issue please, so you will get notified when we manage to address this particular issue. Hope that helps, Piotr

            > From: Sedlock David (LQKG IT RDS)
            > Sent: 11 February 2015 15:04
            > To: 'pswiecicki@atlassian.com'
            > Subject: Crucible 3.6 release notes: "The diff calculation times for the review
            > and changeset pages have been significantly reduced"
            >
            > Hi Piotr,
            >
            > I find the above statement in the release notes, but the issue that I have been
            > following - https://jira.atlassian.com/browse/CRUC-4184 - is still unresolved
            > and I can find no Jira issue in the Crucible release notes that addresses
            > improvements in "diff calculation times". Please explain.
            >
            > Are the problems reported in CRUC-4184 fixed or not?
            >
            > Regards,
            > David

            Intel CHD Jira Admin added a comment - > From: Sedlock David (LQKG IT RDS) > Sent: 11 February 2015 15:04 > To: 'pswiecicki@atlassian.com' > Subject: Crucible 3.6 release notes: "The diff calculation times for the review > and changeset pages have been significantly reduced" > > Hi Piotr, > > I find the above statement in the release notes, but the issue that I have been > following - https://jira.atlassian.com/browse/CRUC-4184 - is still unresolved > and I can find no Jira issue in the Crucible release notes that addresses > improvements in "diff calculation times". Please explain. > > Are the problems reported in CRUC-4184 fixed or not? > > Regards, > David

            This is a blocker for wide deployment in our case, performance on pre-submit diffs for files with 10k+ lines is so poor that our developers are refusing to use Crucible!

            Mikko Hyvärinen added a comment - This is a blocker for wide deployment in our case, performance on pre-submit diffs for files with 10k+ lines is so poor that our developers are refusing to use Crucible!

            1.5 years later and I'm asking the same question: when?
            -David

            Intel CHD Jira Admin added a comment - 1.5 years later and I'm asking the same question: when? -David

            Intel CHD Jira Admin added a comment - - edited

            Hi Sten, thanks for the honest reply. We'll be following the issue and probably delaying our purchase till we find it resolved. If you want to experience what our evaluation users experience, go to https://support.atlassian.com/browse/FSH-10000, where I uploaded a video (https://support.atlassian.com/secure/attachment/499883/crucible_vs_fisheye_diff_performance.mp4).

            BTW, in general no one here is saying anything negative about fisheye/crucible performance, except for this one case!

            Intel CHD Jira Admin added a comment - - edited Hi Sten, thanks for the honest reply. We'll be following the issue and probably delaying our purchase till we find it resolved. If you want to experience what our evaluation users experience, go to https://support.atlassian.com/browse/FSH-10000 , where I uploaded a video ( https://support.atlassian.com/secure/attachment/499883/crucible_vs_fisheye_diff_performance.mp4 ). BTW, in general no one here is saying anything negative about fisheye/crucible performance, except for this one case!

            Hi adm.jira@lantiq.com,

            We are currently working on improving the performance of Crucible and, while I cannot commit to a date as I do not want to build expectations and disappoint you later, I can ensure you that we are working hard to make Crucible faster and better at handling large changesets.

            I am sorry to hear about the slowness that your users are experiencing and I can understand the resulting frustration. This particular issue (CRUC-4184) is not trivial because of the inline comments rendering which would require a change of the structure. On top of that Crucible has to deal with more context than FishEye in case of iterative reviews, which involves more processing around the diffs.

            I want to be honest with you and this issue is not likely to be solved in the upcoming release but we're looking at other performance improvements that are going to make the product better.

            Regards,

            Sten Pittet
            FishEye / Crucible Product Manager

            Sten Pittet (Inactive) added a comment - Hi adm.jira@lantiq.com , We are currently working on improving the performance of Crucible and, while I cannot commit to a date as I do not want to build expectations and disappoint you later, I can ensure you that we are working hard to make Crucible faster and better at handling large changesets. I am sorry to hear about the slowness that your users are experiencing and I can understand the resulting frustration. This particular issue ( CRUC-4184 ) is not trivial because of the inline comments rendering which would require a change of the structure. On top of that Crucible has to deal with more context than FishEye in case of iterative reviews, which involves more processing around the diffs. I want to be honest with you and this issue is not likely to be solved in the upcoming release but we're looking at other performance improvements that are going to make the product better. Regards, Sten Pittet FishEye / Crucible Product Manager

            A speedup of the display is crucial for us: we have users that will not tolerate the typical load time we are experiencing in the diff page in our evaluation of crucible.

            It's very simple: if this isn't speeded up to be very comparable to the fisheye diff time, we won't buy.

            Intel CHD Jira Admin added a comment - A speedup of the display is crucial for us: we have users that will not tolerate the typical load time we are experiencing in the diff page in our evaluation of crucible. It's very simple: if this isn't speeded up to be very comparable to the fisheye diff time, we won't buy.

            We had originally opened up support case CRC-1935 on performance issues while working on reviews, and was pointed to this issue.

            We have noticed that diffs take a long time to load, scrolling is slow, comments take a long time to create & post. The larger the review or the longer you are working in a review, the slower the performance. This has gradually gotten worse over the past few months; the performance in the past has not been this poor.

            We haven't been seeing any memory errors on the server side, so I'd like to know what performance enhancements can be done on the underlying web server?

            Application Services added a comment - We had originally opened up support case CRC-1935 on performance issues while working on reviews, and was pointed to this issue. We have noticed that diffs take a long time to load, scrolling is slow, comments take a long time to create & post. The larger the review or the longer you are working in a review, the slower the performance. This has gradually gotten worse over the past few months; the performance in the past has not been this poor. We haven't been seeing any memory errors on the server side, so I'd like to know what performance enhancements can be done on the underlying web server?

              Unassigned Unassigned
              jxie Chii (Inactive)
              Votes:
              20 Vote for this issue
              Watchers:
              21 Start watching this issue

                Created:
                Updated: