Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-190

Ability to approve / reject reviews similarly to JIRA

    XMLWordPrintable

Details

    • Suggestion
    • Resolution: Unresolved
    • None
    • Code reviews
    • Should work for all environments
    • 3
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

    Description

      It would be great if Crucible reviews could be configured in the same way the JIRA workflows work.

      What we'd like to be able to do, is for certain projects (ie: code review) define a process such as:

      "New Review" (add reviewers, moderators etc) (can be transitioned to "Review in Progress" by the "Start Review" action)
      "Review In Progress" (Can transition back to "New Review" by the "", Approve and Reject)
      Either:

      • Approved (can be transitioned to "Closed" via the "Close Review" action)
      • Rejected (can be transitioned to "Feedback" via the "Give Feedback" action)
        "Feedback" (read-only, can be used to discuss with participants etc. Can be transitioned to "Closed" by the "Close Review" action)
        Closed (no transitions for this status).

      We can also envisage other work flows for different types of reviews (IE: Document or Specification reviews)

      This is probably a huge change request, so a possibly smaller solution which would meat our requirements would be to simply support the notion (via a property/metadata that we can query via the new API) of "Approved/Rejected".

      We want our release software (which pushes changes between our environments) to be able to query a changeset for it's review, and then only allow the release if the review has:

      A) Been completed
      B) Been approved

      If the review has been rejected that change set should not be allowed to go out into production (the fixes required would be another change set and thus another review, which would hopefully be approved and thus allowed out into to big bad world.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              45c16f7e35ca Michael Shimmins
              Votes:
              17 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

                Created:
                Updated: