Image-attachment popup design causes image attachments to fail

(Copied and pasted from Benjamin Naftzger [Atlassian] under CONF-8704, relogged as a bug since it is unexpected behaviour causing loss of work)

This applies to the Image-popup which apparently only gets triggered from the wysiwyg-editor.

I was wondering why attaching images was failing, however it turns out we just have some rather poorly designed UI.

When you go to add an image to an existing page, the course of action that I attempted (wanted) was to:

1. Browse and select an image to attach
2. Click ok
3. See my image attached to the page

Instead, the attach file / browse operation is presented in the middle of the screen. If I click on this and click ok, I am presented with an alert that I need to enter a filename (which also means we have two fields on the one screen referring to filenames (one remote and one local) which could be deemed as confusing and not friendly for business users). This in itself is slightly annoying and should be improved by resolving CONF-6597.

But the absolute worst thing is that, if you then click OK, it closes the window and displays a broken image icon in the rich text editor.

The problem, is due to the fact that there is another button called "Attach", which must be clicked, before clicking "OK".

Also, the Attach File 'Browse' operation should be at the top of the screen, given that this is what you are actually trying to do. You want to work out which file to attach and then just attach it so no doubt this should be prioritised to the top of the screen.