Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-59900

Checking inline tasks will cause unpublished tasks to be set incorrectly

XMLWordPrintable

      We don't plan to backport the fix for this bug to earlier Long Term Support versions

      The fix for this bug isn't suitable for backporting to a bug fix release for any previous LTS versions. This is due to the fix requiring significant changes to multiple components, some of which are not technically feasible on the 8.0 Platform.

      The fix for this issue will be included in future Long Term Support versions.

      Issue Summary

      If inline tasks are being worked on when editing a confluence page, and these published pages have tasks that are being checked or unchecked by others, the wrong task states will be published when the draft is published.

      Example video: tasks-checked-incorrectly.mov

      This may be related to another issue observed in CONFSERVER-59676 where drafts do not show the Unpublished Changes warning message when tasks are modified.

      Steps to Reproduce

      1. Create a page with two or three task elements and publish the page without checking any tasks
      2. Edit the page again and create a new task between the existing ones (but don't publish and stay in edit mode)
      3. Open the same page in a second tab in view mode and check all the tasks
      4. In the first tab, you will now see that the wrong tasks are checked
      5. The then published page will have incorrect task states

      Expected Results

      When task states are changed by others in published pages the state will be updated or notified in their drafts or edited pages.

      Actual Results

      Changing task states in published pages will incorrectly overwrite the state of any new tasks that have been added or changed in edited pages.

      Workaround

      There is currently no workaround

        1. tasks-checked-incorrectly.mov
          5.48 MB

            [CONFSERVER-59900] Checking inline tasks will cause unpublished tasks to be set incorrectly

            James Whitehead added a comment -

            A fix for this issue is available in Confluence Data Center 9.0.1.
            Upgrade now or check out the Release Notes to see what other issues are resolved.

            James Whitehead added a comment - A fix for this issue is available in Confluence Data Center 9.0.1. Upgrade now or check out the Release Notes to see what other issues are resolved.

            James Ponting added a comment - - edited

            Hi All,

            One final brief update.

            We received the fixed upstream dependency and have been able to integrate it as part of our Confluence 9.0 Platform release. Unfortunately the fix precludes backporting as it requires significant changes to the platform that can't safely be undertaken on a LTS release.

            The fix will be available in the first Confluence 9 LTS release planned later this year.

            Thanks,
            James Ponting
            Engineering Manager - Confluence Data Center

            James Ponting added a comment - - edited Hi All, One final brief update. We received the fixed upstream dependency and have been able to integrate it as part of our Confluence 9.0 Platform release. Unfortunately the fix precludes backporting as it requires significant changes to the platform that can't safely be undertaken on a LTS release. The fix will be available in the first Confluence 9 LTS release planned later this year. Thanks, James Ponting Engineering Manager - Confluence Data Center

            James Ponting added a comment -

            Hi All,

            Just a brief update on this one.

            We've ended up with a resolution that has required a change to an upstream dependency in our editor in order to be confident in the quality/safety of the fix.

            After discussions, the upstream vendor has agreed to make the requested change and we're awaiting their implementation to finalise our fix.

            Again, we'll update when we have more.

            Thanks,
            James Ponting
            Engineering Manager - Confluence Data Center

            James Ponting added a comment - Hi All, Just a brief update on this one. We've ended up with a resolution that has required a change to an upstream dependency in our editor in order to be confident in the quality/safety of the fix. After discussions, the upstream vendor has agreed to make the requested change and we're awaiting their implementation to finalise our fix. Again, we'll update when we have more. Thanks, James Ponting Engineering Manager - Confluence Data Center

            James Ponting added a comment -

            Hi All,

            I just wanted to provide some context and an update on the progress of this issue.

            The root cause of this issue is in the way our editor creates task lists, and then how Synchrony (our collaborative editing system) reconciles the changes between a newly published page (such as when a checkbox is checked), and the existing draft. To massively simplify the problem, the diff functionality in Synchrony reconciles the two lists of tasks based on the tasks position in the task list, rather than based on the ID of the task. There are a host of reasons this is the case and desired behaviour generally, but it causes the unwanted behaviour described above in the case of the task list.

            As part of resolving this we have investigated making changes in the editor, in Confluence, and in Synchrony to try and find the solution with the least potential impact and risk. The resolution we decided upon requires making changes to the way the diff algorithm works, which is obviously a broad reaching and highly impactful change. As a result, we're spending a lot of time making sure that the outcome we've chosen is de-risked as far as is possible and will not introduce additional problems.

            I understand on the surface this seems simple and an easy fix, however it's proven to be a complex change, and we're treating it as such. The two highest impact bugs in Confluence's history came about due to problems introduced in Synchrony.

            At this time, I do not have an update as to when the issue will be resolved, but wanted to let you know we are working on it, and hope to have an update soon.

            Thanks,
            James Ponting
            Engineering Manager - Confluence Data Center

            James Ponting added a comment - Hi All, I just wanted to provide some context and an update on the progress of this issue. The root cause of this issue is in the way our editor creates task lists, and then how Synchrony (our collaborative editing system) reconciles the changes between a newly published page (such as when a checkbox is checked), and the existing draft. To massively simplify the problem, the diff functionality in Synchrony reconciles the two lists of tasks based on the tasks position in the task list, rather than based on the ID of the task. There are a host of reasons this is the case and desired behaviour generally, but it causes the unwanted behaviour described above in the case of the task list. As part of resolving this we have investigated making changes in the editor, in Confluence, and in Synchrony to try and find the solution with the least potential impact and risk. The resolution we decided upon requires making changes to the way the diff algorithm works, which is obviously a broad reaching and highly impactful change. As a result, we're spending a lot of time making sure that the outcome we've chosen is de-risked as far as is possible and will not introduce additional problems. I understand on the surface this seems simple and an easy fix, however it's proven to be a complex change, and we're treating it as such. The two highest impact bugs in Confluence's history came about due to problems introduced in Synchrony. At this time, I do not have an update as to when the issue will be resolved, but wanted to let you know we are working on it, and hope to have an update soon. Thanks, James Ponting Engineering Manager - Confluence Data Center

            Achim Herwig [TNG] added a comment - - edited

            At least the names of all the sprints added to this issue are slightly amusing 😬.

            Achim Herwig [TNG] added a comment - - edited At least the names of all the sprints added to this issue are slightly amusing 😬.

            David J added a comment -

            Can't believe something like this has been open for 2.5 years now...

            David J added a comment - Can't believe something like this has been open for 2.5 years now...

            Gerrit Berberich added a comment -

            Is there an expected date of completion? the ticket is assigned to Atlassian Sprints since February 2022 (~7 months). Thanks

            Gerrit Berberich added a comment - Is there an expected date of completion? the ticket is assigned to Atlassian Sprints since February 2022 (~7 months). Thanks

            Michaela Kuenkler added a comment -

            we are on 7.13.7 server - bug still exists

            Michaela Kuenkler added a comment - we are on 7.13.7 server - bug still exists

            Leszek Czaplis added a comment -

            Please confirm which LTS 7.13 release will include a fix for this issue.

            Leszek Czaplis added a comment - Please confirm which LTS 7.13 release will include a fix for this issue.

            Deleted Account (Inactive) added a comment -

            Bug appears in 7.13.2 too.

            Deleted Account (Inactive) added a comment - Bug appears in 7.13.2 too.

              mfedoryshyn Maksym Fedoryshyh
              wmasters Will Masters
              Affected customers:
              113 This affects my team
              Watchers:
              91 Start watching this issue

                Created:
                Updated:
                Resolved: