Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-49930

Stop shimming indexOf

XMLWordPrintable

      NOTE: This bug report is for Confluence Server. Using Confluence Cloud? See the corresponding bug report.

      Team Calendars currently adds an indexOf function to the array prototype.

      Like so:

      }if(!Array.prototype.indexOf){Array.prototype.indexOf=function(B){for(var A=0;"...

      This means that anybody developing against an instance with TC on can easily introduce bugs like https://jira.atlassian.com/browse/CONF-30863 by relying on the existence of indexOf.

      (It also makes QAing confusing).

            [CONFSERVER-49930] Stop shimming indexOf

            DavidA added a comment -

            That is weird, I don't remember us adding anything like that. Might be a library, or faulty human memory.

            DavidA added a comment - That is weird, I don't remember us adding anything like that. Might be a library, or faulty human memory.

            Don Willis added a comment -

            Another option is to add the shims to Confluence-core (or AUI) as well, so at least Confluence behaves consistently regardless of TC's presence.

            Don Willis added a comment - Another option is to add the shims to Confluence-core (or AUI) as well, so at least Confluence behaves consistently regardless of TC's presence.

            Matthew Erickson added a comment -

            Looks like timeline.js is shimming both indexOf() and forEach(). We will have to find a way to take out the shim without modifying timeline.js too much (it's a 3rd party library).

            Damn you IE8!

            Matthew Erickson added a comment - Looks like timeline.js is shimming both indexOf() and forEach(). We will have to find a way to take out the shim without modifying timeline.js too much (it's a 3rd party library). Damn you IE8!

              dchui DavidA
              don.willis@atlassian.com Don Willis
              Affected customers:
              0 This affects my team
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: