Uploaded image for project: 'Confluence Cloud'
  1. Confluence Cloud
  2. CONFCLOUD-67745

Comments on attachments don't work with new editor

XMLWordPrintable

    • 6
    • 29
    • Hide

      Hi everyone,
      This is Shubh Trivedi from the Confluence Cloud Comments team. Thanks for taking the time to vote, comment or watch this ticket. Your feedback continues to help guide our efforts in improving the Atlassian commenting experience.
      We wanted to let you know that this suggestion is not currently in our short term roadmap. However, we’re evaluating this feature for our future roadmap. We encourage you to keep tracking this ticket for future updates.
      Best,
      Shubh

      Show
      Hi everyone, This is Shubh Trivedi from the Confluence Cloud Comments team. Thanks for taking the time to vote, comment or watch this ticket. Your feedback continues to help guide our efforts in improving the Atlassian commenting experience. We wanted to let you know that this suggestion is not currently in our short term roadmap. However, we’re evaluating this feature for our future roadmap. We encourage you to keep tracking this ticket for future updates. Best, Shubh

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      Summary

      In the new editor, the function to comment on images and files on Confluence is not working as expected. The comments dialog box doesn't render to write a comment for the files.

      Environment

      • Confluence Cloud
      • New editor

      Steps to Reproduce

      1. On the new editor, create a test page and upload a file.
      2. Navigate to .... > Click on Attachments > Select the file.
      3. Click on View
      4. Drag the pin icon from the bottom of the preview and drop it where you want to comment.

      Expected Results

      It should present the window for writing the text.

      Actual Results

      It doesn't render at all

      Notes

      • The developer console will show below error 
        com.atlassian.confluence.plugins.confluence-previews:annotation-plugin.js?externals=__local-default__&locale=en-GB:150 Uncaught TypeError: this.errorCallback is not a function
    at e.<anonymous> (com.atlassian.confluence.plugins.confluence-previews:annotation-plugin.js?externals=__local-default__&locale=en-GB:150)
    at d (VM2962 jquery-min.js:1)
    at Object.fireWith (VM2962 jquery-min.js:1)
    at Object.fire [as reject] (VM2962 jquery-min.js:1)
    at Object.<anonymous> (com.atlassian.confluence.plugins.quickedit:quick-edit-general.js?externals=__local-default__&locale=en-GB:13)
    at d (VM2962 jquery-min.js:1)
    at Object.fireWith (VM2962 jquery-min.js:1)
    at Object.fire (VM2962 jquery-min.js:1)
    at d (VM2962 jquery-min.js:1)
    at Object.fireWith (VM2962 jquery-min.js:1)
      • The request header for this element will show status as 200 and preview shows limited payload: 
        {results: [], start: 0, limit: 100, size: 0,…}
limit: 100
results: []
size: 0
start: 0
_links: {base: "https://srandhawa.atlassian.net/wiki", context: "/wiki",…}
base: "https://srandhawa.atlassian.net/wiki"
context: "/wiki"
self: "https://srandhawa.atlassian.net/wiki/rest/files/1.0/files/697925655/comments?attachmentVersion=1"
      • Comparing with old editor where all the information is parsed: 
        {id: "40828933", history: {latest: true,…},…}
anchor: {type: "pin", page: 1, x: 0.7663398692810458, y: 0.9363636363636364}
body: {editor: {value: "<p>Testing with image comments</p>", representation: "editor",…},…}
editor: {value: "<p>Testing with image comments</p>", representation: "editor",…}
view: {value: "<p>Testing with image comments</p>", representation: "view",…}
_expandable: {atlas_doc_format: "", export_view: "", styled_view: "", storage: "", editor2: "",…}
children: []
hasDeletePermission: true
hasEditPermission: true
hasReplyPermission: true
hasResolvePermission: true
history: {latest: true,…}
id: "40828933"
resolved: {value: false,…}
by: {type: "unknown", username: "unknown", displayName: "Unlicensed user", userKey: "", operations: null}
displayName: "Unlicensed user"
operations: null
type: "unknown"
userKey: ""
username: "unknown"
value: false
version: {by: {type: "known", accountId: "5b7caf50332df52a5d9449d8", accountType: "atlassian",…},…}
by: {type: "known", accountId: "5b7caf50332df52a5d9449d8", accountType: "atlassian",…}
friendlyWhen: "yesterday at 2:01 PM"
message: ""
minorEdit: false
number: 1
when: "2019-09-02T08:31:01.067Z"
_expandable: {collaborators: "", content: "/rest/api/content/40828933"}
collaborators: ""
content: "/rest/api/content/40828933"
_links: {self: "https://skhanna.atlassian.net/wiki/rest/api/content/40828933/version/1"}
self: "https://skhanna.atlassian.net/wiki/rest/api/content/40828933/version/1"
_links: {base: "https://skhanna.atlassian.net/wiki", context: "/wiki"}
base: "https://skhanna.atlassian.net/wiki"
context: "/wiki"

      Workaround

      Currently, there is no workaround for this issue

            [CONFCLOUD-67745] Comments on attachments don't work with new editor

            Kelly Arrey added a comment -

            Our Tech Writing team put together some things to consider around why adding inline comments to an attached PDF is a superior collaboration solution to adding inline comments to the content in a Confluence page:

            • Search pollution: As each new version of each document for each product is added, it becomes harder to search for content.
            • Performance: We're working with fairly small documents, but we don't know how well this would work for larger documents. Also, when Confluence works with a PDF, it has to handle only one file; when you add images, suddenly it has to manage hundreds more behind the scenes, which seems likely to slow down processing.
            • Storage: When you paste content, it includes new copies of bitmap images for each version. Like, each version in the Page History. Some of these images can end up bigger than the compressed versions in PDFs. (Some might be smaller, too.)
            • Efficiency: For content we release as PDFs (eg. Release Notes, OSL docs), we can literally just drag the PDF right in the attachments. To use the raw-Confluence-comment workaround, I need to publish the Release Notes to our UAT docs portal, use our docs portal's Print Topics feature (to get a print-friendly version), and carefully copy-paste the results to the Confluence page. (Then remember to delete it from UAT later, since our licensing is based on amount of content.)
            • Consistency: We can use the same plugin for PDFs and Word documents, and (as I understand it) other document types too.
            • Formatting: Content pasted into a Confluence page changes the formatting, meaning people aren't seeing the content as it will appear (eg. with the correct bolding, heading, page indentation, etc.). Some styles come across, but not all. With the PDF feedback plugin, people are seeing the PDFs exactly as customers will get them.

            Kelly Arrey added a comment - Our Tech Writing team put together some things to consider around why adding inline comments to an attached PDF is a superior collaboration solution to adding inline comments to the content in a Confluence page: Search pollution:  As each new version of each document for each product is added, it becomes harder to search for content. Performance:  We're working with fairly small documents, but we don't know how well this would work for larger documents. Also, when Confluence works with a PDF, it has to handle only one file; when you add images, suddenly it has to manage hundreds more behind the scenes, which seems likely to slow down processing. Storage:  When you paste content, it includes new copies of bitmap images for each version. Like, each version in the Page History. Some of these images can end up bigger than the compressed versions in PDFs. (Some might be smaller, too.) Efficiency:  For content we release as PDFs (eg. Release Notes, OSL docs), we can literally just drag the PDF right in the attachments. To use the raw-Confluence-comment workaround, I need to publish the Release Notes to our UAT docs portal, use our docs portal's Print Topics feature (to get a print-friendly version), and carefully copy-paste the results to the Confluence page. (Then remember to delete it from UAT later, since our licensing is based on amount of content.) Consistency: We can use the same plugin for PDFs and Word documents, and (as I understand it) other document types too. Formatting: Content pasted into a Confluence page changes the formatting, meaning people aren't seeing the content as it will appear (eg. with the correct bolding, heading, page indentation, etc.). Some styles come across, but not all. With the PDF feedback plugin, people are seeing the PDFs exactly as customers will get them.

            Kelly Arrey added a comment -

            Hi @owallis, as noted by all the commenters above, this is a very valuable function for collaboration, and certainly deserves a higher priority than a lot of the changes that are being implemented (like page header images - seriously?). Please move this up the backlog. Thanks!!!

            Kelly Arrey added a comment - Hi @owallis, as noted by all the commenters above, this is a very valuable function for collaboration, and certainly deserves a higher priority than a lot of the changes that are being implemented (like page header images - seriously?). Please move this up the backlog. Thanks!!!

            Tim-Oliver Schulz added a comment -

            The macro workaround from above cannot be the solution!
            Yes, it works somehow... but 3 different ways of opening the preview leads to 3 different option-setups in preview-mode - really?!

            As it seems to be working, please make all 12 options available in the other previews as well and make Confluence great again.

            1. Click on image thumbnail on page -> available options:
              1. zoom
              2. next
              3. prev
              4. download
              5. close
            2. Click on "..." -> Attachments -> Files -> View -> available options:
              1. zoom
              2. fullscreen
              3. presentation
              4. next
              5. prev
              6. version selection
              7. upload new version
              8. download
              9. share
              10. close
            3. Macro-Workaround from above -> available options:
              1. zoom
              2. fullscreen
              3. presentation
              4. comment
              5. next
              6. prev
              7. version selection
              8. upload new version
              9. download
              10. comments
              11. share
              12. close

            Tim-Oliver Schulz added a comment - The macro workaround from above cannot be the solution! Yes, it works somehow... but 3 different ways of opening the preview leads to 3 different option-setups in preview-mode - really?! As it seems to be working, please make all 12 options available in the other previews as well and make Confluence great again. Click on image thumbnail on page -> available options: zoom next prev download close Click on "..." -> Attachments -> Files -> View -> available options: zoom fullscreen presentation next prev version selection upload new version download share close Macro-Workaround from above -> available options: zoom fullscreen presentation comment next prev version selection upload new version download comments share close

            Daniel Schmidt added a comment - - edited

            I am seeing the same behavior, and adding an attachments widget, selecting the preview out of the attachments widget workaround suggested isn't working. This is a big hinderance to collaboration.

            Daniel Schmidt added a comment - - edited I am seeing the same behavior, and adding an attachments widget, selecting the preview out of the attachments widget workaround suggested isn't working. This is a big hinderance to collaboration.

            Ken Collins added a comment -

            we are seeing similar issue, we can drag the pin to a spot on the doc and the comment icon will appear in that selected spot, however the panel at far right shows the user with a spinning wheel beneath and then all freezes

            Ken Collins added a comment - we are seeing similar issue, we can drag the pin to a spot on the doc and the comment icon will appear in that selected spot, however the panel at far right shows the user with a spinning wheel beneath and then all freezes

            Cameron Gull added a comment -

            The "solution" to use the Attachments is really not a solution. A user should simply be able to drag a PDF to the page, click on the thumbnail of the PDF which previews the PDF inline and drag the pin to the area they would like to add a comment.

            As it stands now, users have to add using the attachment macro, then click on the flag on the left to expand and then click View. Only then can users drag the comment pin. Nobody will intuitively be able to figure that out.

            Please fix.

             

            Cameron Gull added a comment - The "solution" to use the Attachments is really not a solution. A user should simply be able to drag a PDF to the page, click on the thumbnail of the PDF which previews the PDF inline and drag the pin to the area they would like to add a comment. As it stands now, users have to add using the attachment macro, then click on the flag on the left to expand and then click View. Only then can users drag the comment pin. Nobody will intuitively be able to figure that out. Please fix.  

            Mirko Schäfer (Seibert Solutions) added a comment -

            I have to correct my previous post: it does work with the described workaround by using the attachment MACRO.

            But, honestly, that is not really a final solution, right?

            Commenting by just klicking on a file rendered in a page is essential for collaborating. Could you please let us know if the inline comment function will be integrated in the new editor rendering? If yes, what is the planned timeline?

            Mirko Schäfer (Seibert Solutions) added a comment - I have to correct my previous post: it does work with the described workaround by using the attachment MACRO. But, honestly, that is not really a final solution, right? Commenting by just klicking on a file rendered in a page is essential for collaborating. Could you please let us know if the inline comment function will be integrated in the new editor rendering? If yes, what is the planned timeline?

            Mirko Schäfer (Seibert Solutions) added a comment -

            It does not work at all - please reopen this issue, it has definently not been fixed or is buggy again.

            Cheers, Mirko

            Mirko Schäfer (Seibert Solutions) added a comment - It does not work at all - please reopen this issue, it has definently not been fixed or is buggy again. Cheers, Mirko

            Kelly Arrey added a comment - - edited
            • You need to use the `/attachments` macro to list the attachments
            • Expand the relevant attachment
            • Click View to open the preview
            • The comment bubble is then sometimes visible. Sometimes mousing over the preview brings up a small toolbar at the bottom with 4 buttons:
              • zoom out
              • zoom in
              • fit to page
              • start presentation
                Sometimes there's a fifth button to "drag this pin to add a comment". If it's not there, try refreshing the page. Best of luck.

            More here: https://support.atlassian.com/confluence-cloud/docs/insert-the-attachments-macro/

            Kelly Arrey added a comment - - edited You need to use the `/attachments` macro to list the attachments Expand the relevant attachment Click View to open the preview The comment bubble is then sometimes visible. Sometimes mousing over the preview brings up a small toolbar at the bottom with 4 buttons: zoom out zoom in fit to page start presentation Sometimes there's a fifth button to "drag this pin to add a comment". If it's not there, try refreshing the page. Best of luck. More here: https://support.atlassian.com/confluence-cloud/docs/insert-the-attachments-macro/

            Richard Gomez added a comment -

            This has been fixed and released to prod

            Richard Gomez added a comment - This has been fixed and released to prod

              e8931b7d41d8 Shubh Trivedi
              srandhawa@atlassian.com Supreet (Inactive)
              Votes:
              140 Vote for this issue
              Watchers:
              88 Start watching this issue

                Created:
                Updated: