Back/forward buttons break dynamic macros in Confluence

XMLWordPrintable

    • Severity 3 - Minor

      Hi,

      Originally: DEVHELP-572

      Issue was discovered by some of our customers. The error message we show is a message for another situation as we haven't explicitly handled this particular case: When back/forward is used our server isn't sent the macro parameters required to render the macro.

      Steps:

      1. If you have the Chrome developer console open, ensure the "Disable cache" option isn't ticked in Network tab
      2. View a page with a dynamic macro
      3. Wait a few minutes (or pretend to read the page)
      4. Click the browser Back button
      5. Click the browser Forward button

      Add-on: Macro Toolbox for Cloud
      (well really any add-on with a dynamic macro)
      Test page: https://goodsoftwarestaging.atlassian.net/wiki/x/AYAh
      Browser tested: Chrome 58.0.3029.110 (64-bit) on OSX 10.12.4

      // NOTE that the parameters for the macro are missing from the URL in the Connect iframe. This means it's not possible for our server to render the macro
      
      <iframe ... src="https://macro-toolbox-for-cloud.addonengine.com/dynamicMacro/headingExpand?pageId=2195457&pageVersion=2&pageTitle=&pageType=page&macroId=&outputType=&title=&style=&expanded=&tz=Australia%2FSydney&loc=en-GB&user_id=admin&user_key=ff80808159f8f97e0159f8f9aabb0001&xdm_e=https%3A%2F%2Fgoodsoftwarestaging.atlassian.net&xdm_c=channel-com.addonengine.macrotoolboxforcloud__com-addonengine-macrotoolboxforcloud-macros-heading-expand8774260350795796725&cp=%2Fwiki&xdm_deprecated_addon_key_do_not_use=com.addonengine.macrotoolboxforcloud&lic=active&cv=1.3.19&jwt=[redacted]" ... />
      
      // URL from the descriptor
      
      "url":"/dynamicMacro/headingExpand?pageId={page.id}&pageVersion={page.version}&pageTitle={page.title}&pageType={page.type}&macroId={macro.id}&outputType={output.type}&title={title}&style={style}&expanded={expanded}
      

        1. actual.png
          actual.png
          3.26 MB
        2. issue.gif
          issue.gif
          278 kB
        3. expected.png
          expected.png
          111 kB

              Assignee:
              Einar Pehrson (Inactive)
              Reporter:
              Tim Clipsham
              Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

                Created:
                Updated:
                Resolved: