Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-9358

Merge button does not refresh when PR is approved

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Medium
    • 5.0.0, 4.14.5
    • 4.11.1
    • Pull Requests
    • None

    Description

      Summary

      Similar regression on ---BSERV-3190--- except this is only triggered only after when a user wants to add themselves as a reviewer of a PR. If a user gets invited to a PR instead, this bug doesn't get affected (the 'Merge' button will be enabled or disabled appropriately). 

      Steps to Reproduce

      1. Create a second user and provide write access to a repository
      2. Create a Pull Request and set the minimum number for approval to 1
      3. Login as the second user and add as a reviewer of the Pull Request
      4. Approve that PR

      Expected Results

      The Merge button is enabled and a comment saying that the second user had approve the PR

      Actual Results

      The Merge button is still disabled and nothing is written on the comment

      Workaround

      Refresh the PR page. After refreshing, the merge button should work as expected if the conditions are met. 

      Attachments

        1. pr-approval-4.10.1.mp4
          398 kB
        2. pr-approval-4.11.2.mp4
          1.06 MB
        3. screenshot.png
          screenshot.png
          77 kB
        4. Screen Shot 2019-04-19 at 2.28.50 PM.png
          Screen Shot 2019-04-19 at 2.28.50 PM.png
          635 kB
        5. Screen Shot 2019-04-19 at 3.24.09 PM.png
          Screen Shot 2019-04-19 at 3.24.09 PM.png
          589 kB

        Issue Links

          Activity

            People

              khughes@atlassian.com Kristy
              aer Andrew Er (Inactive)
              Votes:
              3 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: