Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-5233

Allow the creation of tasks without requiring a comment

    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      Atlassian status as of March 2020

      Hi all,

      I'm excited to share that in Bitbucket Server 7.0 we shipped redesigned and optimized pull request page with several improvements you’ve been asking us for a long time. One of the improvements is the new tasks, which can now be created without parent comment.

      Please, don't hesitate to leave feedback on the feature in the comments below. We would like to know if new tasks solve your problems. 

      You can find more information in the Bitbucket Server 7.0 release notes and Pull Requests documentation.

      Anton Genkin
      Product Manager Bitbucket Server

      Original description
      My team loves the new tasks; they certainly make the review process much nicer!

      It would be really great if you could create task items directly on the diffs without having to create a comment first. Sometimes the task is large enough to need a comment, and then break it out in to tasks. Other times it's a simple task like "Add javadocs".

      There are a couple of other possibilities for this:

      • Asking for changes to files that haven't been modified yet (example: "Add missing changes to ThisOtherService.java")
      • Grouping together changes for multiple files (example: "Clean up the changes in the com.example.controllers package")

            [BSERV-5233] Allow the creation of tasks without requiring a comment

            Hi all,

            I'm excited to share that in Bitbucket Server 7.0 we shipped redesigned and optimized pull request page with several improvements you’ve been asking us for a long time. One of the improvements is the new tasks, which can now be created without parent comment.

            Please, don't hesitate to leave feedback on the feature in the comments below. We would like to know if new tasks solve your problems. 

            You can find more information in the Bitbucket Server 7.0 release notes and Pull Requests documentation.

            Anton Genkin
            Product Manager Bitbucket Server

            Anton Genkin (Inactive) added a comment - Hi all, I'm excited to share that in Bitbucket Server 7.0 we shipped redesigned and optimized pull request page with several improvements you’ve been asking us for a long time. One of the improvements is the new tasks, which can now be created without parent comment. Please, don't hesitate to leave feedback on the feature in the comments below. We would like to know if new tasks solve your problems.  You can find more information in the Bitbucket Server 7.0  release notes and Pull Requests documentation . Anton Genkin Product Manager Bitbucket Server

            This should be similar to the "Needs Resolution" feature in Crucible (a sister Atlassian code review product), where the comment itself may be marked as "Needs Resolution," which is essentially equivalent to pull request "tasks"

            Stan Vaysburd added a comment - This should be similar to the "Needs Resolution" feature in Crucible (a sister Atlassian code review product), where the comment itself may be marked as "Needs Resolution," which is essentially equivalent to pull request "tasks"

            Trejkaz added a comment -

            As tasks are only a workaround for comments not working correctly in the first place, I think it would be far better if comments simply always had to be addressed. For some small number of comments the person making the comment could mark it as already addressed / unimportant, but the vast majority of comments are for actual changes to be made, and it's too errorprone at the moment because when new commits come in you have no idea what has been addressed.

            Trejkaz added a comment - As tasks are only a workaround for comments not working correctly in the first place, I think it would be far better if comments simply always had to be addressed. For some small number of comments the person making the comment could mark it as already addressed / unimportant, but the vast majority of comments are for actual changes to be made, and it's too errorprone at the moment because when new commits come in you have no idea what has been addressed.

            Andy Garcia added a comment - - edited

            Any progress on this? I would even be happy with it being able to put a simple checkbox in the description of the pull request as markdown

            Andy Garcia added a comment - - edited Any progress on this? I would even be happy with it being able to put a simple checkbox in the description of the pull request as markdown

            After about 12 months, is there any hope that someone starts this task?

            Farshad Sheykhi added a comment - After about 12 months, is there any hope that someone starts this task?

            It's sensible that your data model requires tasks to be attached to comments.  I think I would settle for an "add task" button in the comment editing toolbar, so that you can create the tasks inline with the comment.  Another alternative would be a "Convert to task" button that would do the equivalent of selecting the entire comment and adding it as a task.

            Justin Gregory added a comment - It's sensible that your data model requires tasks to be attached to comments.  I think I would settle for an "add task" button in the comment editing toolbar, so that you can create the tasks inline with the comment.  Another alternative would be a "Convert to task" button that would do the equivalent of selecting the entire comment and adding it as a task.

            usmanovbf added a comment -

            Oh, God, why is it still unfinished? I think it easy to implement 

            usmanovbf added a comment - Oh, God, why is it still unfinished? I think it easy to implement 

            Thanks @Roger Barnes.

            For the record, we often end up having tasks that tell the exact same thing as the comment they're attached to.

            Gregory Pakosz added a comment - Thanks @Roger Barnes. For the record, we often end up having tasks that tell the exact same thing as the comment they're attached to.

            Hi gpakosz, this is something we'd like to improve someday, but due to other projects it's not on our planning radar for the next 6-12 months, I'm afraid. 

            Roger Barnes (Inactive) added a comment - Hi gpakosz , this is something we'd like to improve someday, but due to other projects it's not on our planning radar for the next 6-12 months, I'm afraid. 

            Can a PM please voice in?

            Gregory Pakosz added a comment - Can a PM please voice in?

            This is a annoying this for us too. Most of our review comments are straightforward, but we have to create a comment and then create a task.

            Please look into this.

            mark_gillespie added a comment - This is a annoying this for us too. Most of our review comments are straightforward, but we have to create a comment and then create a task. Please look into this.

            +1! Seems like we're mostly using the review to create "fix this" kinds of comments, so would be easier if they just went in as tasks without needing to do a comment first.

            Mike Johnson added a comment - +1! Seems like we're mostly using the review to create "fix this" kinds of comments, so would be easier if they just went in as tasks without needing to do a comment first.

            +1 for being able to directly create tasks from a line of code in the PR as described above. I.e. create a task directly without first having to make a comment.

            Nathan McC added a comment - +1 for being able to directly create tasks from a line of code in the PR as described above. I.e. create a task directly without first having to make a comment.

            Hello, and thanks from our team too for adding tasks.

            My request is close to this one, but probably it would make sense to extract it to a separate issue – we'd like the comment itself to be a task.

            Our workflow has grown to be this: a reviewer adds a comment, and it is anticipated that the author would reply to that comment, even with a simple "ok". The goal of the reviewer is not only to provide a feedback, but also see to that either a) the suggestion in the comment gets addressed, or b) the author actively disagrees (and then a discussion ensues).

            It is a failure of the review process if a comment is entered and then forgotten. So we need a kind of "comment was addressed" flag. It would also solve inconvenience when more commits are added to the pull request, and without the replies to the comments, the reviewer doesn't know which of those concerns were intentionally addressed and which weren't.

            The tasks kind of solve this - but not in an ideal way. It often looks like this (I'm simplifying): comment goes "this is a bug", and the task says "fix this bug". This is quite redundant, to the point that the task is rarely used and we still rely on author replying to the comments.

            So, do you think this feedback belongs here or it's better to add a feature request for "comment status"?

            Thanks!
            Igor

            Igor Sereda [ALM Works] added a comment - Hello, and thanks from our team too for adding tasks. My request is close to this one, but probably it would make sense to extract it to a separate issue – we'd like the comment itself to be a task. Our workflow has grown to be this: a reviewer adds a comment, and it is anticipated that the author would reply to that comment, even with a simple "ok". The goal of the reviewer is not only to provide a feedback, but also see to that either a) the suggestion in the comment gets addressed, or b) the author actively disagrees (and then a discussion ensues). It is a failure of the review process if a comment is entered and then forgotten. So we need a kind of "comment was addressed" flag. It would also solve inconvenience when more commits are added to the pull request, and without the replies to the comments, the reviewer doesn't know which of those concerns were intentionally addressed and which weren't. The tasks kind of solve this - but not in an ideal way. It often looks like this (I'm simplifying): comment goes "this is a bug", and the task says "fix this bug". This is quite redundant, to the point that the task is rarely used and we still rely on author replying to the comments. So, do you think this feedback belongs here or it's better to add a feature request for "comment status"? Thanks! Igor

            do you have to go searching for that exact line in the entire pull request diff?

            That would be the implication, for now, yes. The feature request for changing this is STASH-3283

            Roger Barnes (Inactive) added a comment - do you have to go searching for that exact line in the entire pull request diff? That would be the implication, for now, yes. The feature request for changing this is STASH-3283

            Oh, so you can't create a task from commit diff? This is a little unintuitive: e.g. in a large pull request someone submits a one-line commit which you want to comment on and create a task, do you have to go searching for that exact line in the entire pull request diff? In my opinion, it would make a whole lot of sense to allow for task to be created from commit diffs.

            As has been already mentioned above, it would also be nice to be able to create tasks without having to always create a comment first.

            Ivan Smirnov added a comment - Oh, so you can't create a task from commit diff? This is a little unintuitive: e.g. in a large pull request someone submits a one-line commit which you want to comment on and create a task, do you have to go searching for that exact line in the entire pull request diff? In my opinion, it would make a whole lot of sense to allow for task to be created from commit diffs. As has been already mentioned above, it would also be nice to be able to create tasks without having to always create a comment first.

            eric60, thanks for the input. This is something we might consider. I think your other request is largely the same, so I'll go ahead and link them (and close the other).

            aldanor, adding to Brent's comment, comments on commits are not currently considered part of a pull request, and as such cannot have pull request tasks associated. This is something we'd like to improve in a future release.

            Roger Barnes (Inactive) added a comment - eric60 , thanks for the input. This is something we might consider. I think your other request is largely the same, so I'll go ahead and link them (and close the other). aldanor , adding to Brent's comment, comments on commits are not currently considered part of a pull request, and as such cannot have pull request tasks associated. This is something we'd like to improve in a future release.

            Brent P added a comment - - edited

            aldanor - Creating tasks is only available in pull request diffs and not commit diffs. Can you double-check that you've not gone into a commit diff by going to the commit tab in a pull request and clicking on one of the commits?

            If you're in a pull request diff and still can't create tasks, could you please raise a support request at https://support.atlassian.com so we can figure out what's going wrong?

            Brent P added a comment - - edited aldanor - Creating tasks is only available in pull request diffs and not commit diffs. Can you double-check that you've not gone into a commit diff by going to the commit tab in a pull request and clicking on one of the commits? If you're in a pull request diff and still can't create tasks, could you please raise a support request at https://support.atlassian.com so we can figure out what's going wrong?

            Hi Roger,

            The workflow you've shown above doesn't seem to work for me at all (Stash 3.3.1 on Linux) – the "Create task" link seems to be only available below comments in the "Overview" tab of a pull requests, and it's not available for comments in the "Diff" tab. Would you have any idea why this could be happening?

            Thanks.

            Ivan Smirnov added a comment - Hi Roger, The workflow you've shown above doesn't seem to work for me at all (Stash 3.3.1 on Linux) – the "Create task" link seems to be only available below comments in the "Overview" tab of a pull requests, and it's not available for comments in the "Diff" tab. Would you have any idea why this could be happening? Thanks.

            Eric Henry added a comment - - edited

            Hi Roger,
            This is a pretty awesome shortcut, but not exactly what I was thinking. I was hoping that you wouldn't need to create a comment at all.

            When you hover over a line in a pull request diff you see the little comment bubble icon (with the plus sign in the middle) show up in the margin. If clicking that icon could bring up a little context menu where you would choose between a comment or a task, I think that would help tremendously.

            Thanks!

            Eric Henry added a comment - - edited Hi Roger, This is a pretty awesome shortcut, but not exactly what I was thinking. I was hoping that you wouldn't need to create a comment at all. When you hover over a line in a pull request diff you see the little comment bubble icon (with the plus sign in the middle) show up in the margin. If clicking that icon could bring up a little context menu where you would choose between a comment or a task, I think that would help tremendously. Thanks!

            Hi Eric,

            Thanks for the suggestion, and I'm glad you like the feature!

            There is a shortcut for task creation that you can use (and we plan to call it out more in a future release): if you select text from a comment first, and then click "create task", then a task is instantly created using the selection. The animation below shows both approaches. Would this satisfy your needs?

            Roger Barnes (Inactive) added a comment - Hi Eric, Thanks for the suggestion, and I'm glad you like the feature! There is a shortcut for task creation that you can use (and we plan to call it out more in a future release): if you select text from a comment first, and then click "create task", then a task is instantly created using the selection. The animation below shows both approaches. Would this satisfy your needs?

              Unassigned Unassigned
              0ef02ec00948 Eric Henry
              Votes:
              136 Vote for this issue
              Watchers:
              69 Start watching this issue

                Created:
                Updated:
                Resolved: