Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-4282

Chrome 32 crashes when viewing branches, pull requests, or other pages that display time

      Viewing http://.../repos/fmos/branches using Google Chrome Version 32.0.1700.76 m on Windows 7 causes Chrome to display its "Aw, Snap!" error page.

      The same Chrome bug (being tracked at https://code.google.com/p/chromium/issues/detail?id=333594) is visible in the following places:

      • Branches page
      • Pull Requests list page
      • viewing Blame of a file
      • viewing History of a file
      • possibly any other page that displays time information.

      Chrome fix schedule:

      Chromium developers have noted that this should be merged today (Monday Jan 28, 2014), so presumably will be in the next Chrome update.

      Workarounds:

      If this is affecting you, you can try another browser (e.g. Firefox), or install the attached plugin. The plugin provides simpler time-formatting code in Chrome 32 that doesn't hit the Chrome bug. Please be sure to uninstall this plugin once the bug is fixed in Chrome to return to view the nicer time formatting again.

      Chrome 33 has been released. We strongly recommend you upgrade Chrome which will resolve this issue. Stash 2.11 also ships with a new version of Moment.js which prevents the crash in Chrome 32.

            [BSERV-4282] Chrome 32 crashes when viewing branches, pull requests, or other pages that display time

            Chrome 33 has been released. We strongly recommend you upgrade Chrome which will resolve this issue. Stash 2.11 also ships with a new version of Moment.js which prevents the crash in Chrome 32.

            Michael McGlynn (Inactive) added a comment - Chrome 33 has been released. We strongly recommend you upgrade Chrome which will resolve this issue. Stash 2.11 also ships with a new version of Moment.js which prevents the crash in Chrome 32.

            zach1 Chrome hasn't pushed the fix to v32 yet, so the best bet for now is to install the plugin attached to this issue. We'll be shipping an updated version of moment.js in 2.11 which also works around the issue, but there should be a new stable version of Chrome containing the fix for the bug very soon.

            Watching this Chrome issue is the best way to track progress - https://code.google.com/p/chromium/issues/detail?id=333594

            Please only open a new issue if you are seeing a problem not covered by this issue.

            Michael McGlynn (Inactive) added a comment - - edited zach1 Chrome hasn't pushed the fix to v32 yet, so the best bet for now is to install the plugin attached to this issue. We'll be shipping an updated version of moment.js in 2.11 which also works around the issue, but there should be a new stable version of Chrome containing the fix for the bug very soon. Watching this Chrome issue is the best way to track progress - https://code.google.com/p/chromium/issues/detail?id=333594 Please only open a new issue if you are seeing a problem not covered by this issue.

            Zachary added a comment -

            Is the fix in the wild yet? I'll confirm my guy's chrome version and reopen or create a new issue if he is still being affected.

            Zachary added a comment - Is the fix in the wild yet? I'll confirm my guy's chrome version and reopen or create a new issue if he is still being affected.

            Zachary added a comment -

            I attached a minidump stackwalk to this issue from a user who is experiencing this issue in the computer history view in stash. Think it is the same issue, so here it is even tho this looks resolved (thanks!).

            Zachary added a comment - I attached a minidump stackwalk to this issue from a user who is experiencing this issue in the computer history view in stash. Think it is the same issue, so here it is even tho this looks resolved (thanks!).

            Update:
            http://code.google.com/p/chromium/issues/detail?id=333594#c56

            Actually, better news! There will be a Chrome stable push tomorrow, and hopefully by Monday this fix will be fully rolled out.

            So hopefully we should see the fix hit stable on Monday 3rd Feb US time.

            Michael McGlynn (Inactive) added a comment - Update: http://code.google.com/p/chromium/issues/detail?id=333594#c56 Actually, better news! There will be a Chrome stable push tomorrow, and hopefully by Monday this fix will be fully rolled out. So hopefully we should see the fix hit stable on Monday 3rd Feb US time.

            It looks like the fix should be merged to Chrome 32 & 33 on Monday, so unless you are currently finding it unmanageable, it's probably best to wait for the bugfix to come through rather than install the plugin. The plugin shouldn't cause any issues though if you need to install it.

            https://code.google.com/p/chromium/issues/detail?id=333594#c45

            We'll merge to M32 and M33 Monday...

            Michael McGlynn (Inactive) added a comment - It looks like the fix should be merged to Chrome 32 & 33 on Monday, so unless you are currently finding it unmanageable, it's probably best to wait for the bugfix to come through rather than install the plugin. The plugin shouldn't cause any issues though if you need to install it. https://code.google.com/p/chromium/issues/detail?id=333594#c45 We'll merge to M32 and M33 Monday...

            I've attached a plugin which will work around the tab crashing issue in Chrome 32. Specifically we were seeing the crash when using the moment.js library for date formatting. This plugin replaces that codepath with native functionality for formatting dates that should produce very similar output. This replacement is only done in Chrome 32, other browsers will continue to use the existing codepath

            Relative dates (such as "2 days ago") will not be enabled on any pages that aren't rendered on the server (instead it will just give the date in the regular short format, e.g. "22 Jan 2014")

            The plugin will only target Chrome 32 as it seems very likely that the fix will make it's way into Chrome 33. I would recommend uninstalling/disabling the plugin after Chrome 33 is out and your users have been upgraded to it.

            Michael McGlynn (Inactive) added a comment - - edited I've attached a plugin which will work around the tab crashing issue in Chrome 32. Specifically we were seeing the crash when using the moment.js library for date formatting. This plugin replaces that codepath with native functionality for formatting dates that should produce very similar output. This replacement is only done in Chrome 32, other browsers will continue to use the existing codepath Relative dates (such as "2 days ago") will not be enabled on any pages that aren't rendered on the server (instead it will just give the date in the regular short format, e.g. "22 Jan 2014") The plugin will only target Chrome 32 as it seems very likely that the fix will make it's way into Chrome 33. I would recommend uninstalling/disabling the plugin after Chrome 33 is out and your users have been upgraded to it.

            Chrome have fixed this bug in the latest unstable ("Canary ") version of Chrome. They are currently determining how far back to make the fix, and it may be fixed in the next bug fix update or the next full stable version.

            We're still determining if we can release a Stash version that works around this bug in the meantime.

            Adam Ahmed (Inactive) added a comment - Chrome have fixed this bug in the latest unstable ("Canary ") version of Chrome. They are currently determining how far back to make the fix, and it may be fixed in the next bug fix update or the next full stable version. We're still determining if we can release a Stash version that works around this bug in the meantime.

            I have the same issue with Chrome Version 32.0.1700.77 on Mac OS X 10.9.1. Fortunately it only occurs in the branch list.

            Daniel Bächtle added a comment - I have the same issue with Chrome Version 32.0.1700.77 on Mac OS X 10.9.1. Fortunately it only occurs in the branch list.

            I get the same crash when clicking the History button when viewing a file in the code browser.

            Collin Grady added a comment - I get the same crash when clicking the History button when viewing a file in the code browser.

              aahmed Adam Ahmed (Inactive)
              scott.miller Scott Miller
              Affected customers:
              8 This affects my team
              Watchers:
              22 Start watching this issue

                Created:
                Updated:
                Resolved: