Unable to configure Bamboo Web Repository URL to represent a subset of the underlying repository for FishEye

This is most obvious when the FishEye repository is a subset of the underlying SCM repository.

Current example

Facts:

Bamboo allows the specification of a Web Repository URL and an optional Web Repository Module.

when	Example 1
WR URL =		https://extranet.atlassian.com/crucible/browse/FE
WR Module =		(blank)
then	worked?
file link		https://extranet.atlassian.com/crucible/browse/FE/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root= (double repository name, content-type and root= not used)
version link		https://extranet.atlassian.com/crucible/browse/FE/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=&revision=24474&r=24474#r24474
diff link		https://extranet.atlassian.com/crucible/browse/FE/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=&r1=24473&r2=24474
changeset link		https://extranet.atlassian.com/crucible/changelog/FE?cs=24474

when	Example 2
WR URL =		https://extranet.atlassian.com/crucible/browse
WR Module =		(blank)
then	worked?
file link		https://extranet.atlassian.com/crucible/browse/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=
version link		https://extranet.atlassian.com/crucible/browse/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=&revision=24474&r=24474#r24474
diff link		https://extranet.atlassian.com/crucible/browse/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=&r1=24473&r2=24474
changeset link		https://extranet.atlassian.com/crucible/changelog?cs=24474 (no repository name)

when	Example 3
WR URL =		https://extranet.atlassian.com/crucible/browse
WR Module =		FE
then	worked?	(looks similar to last)
file link		https://extranet.atlassian.com/crucible/browse/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=FE (content-type and root not used)
version link		https://extranet.atlassian.com/crucible/browse/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=FE&revision=24474&r=24474#r24474
diff link		https://extranet.atlassian.com/crucible/browse/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=FE&r1=24473&r2=24474
changeset link		https://extranet.atlassian.com/crucible/changelog?cs=24474

when	Example 4
WR URL =		https://extranet.atlassian.com/crucible/viewcvs (viewcvs compatibility)
WR Module =		FE
then	worked?
file link	404	https://extranet.atlassian.com/crucible/viewcvs/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=FE (repname in path and in root=)
	redirects to	https://extranet.atlassian.com/crucible/browse/FE/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java
version link	404	https://extranet.atlassian.com/crucible/viewcvs/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=FE&revision=24474&r=24474#r24474
	redirects to	https://extranet.atlassian.com/crucible/browse/FE/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java#r24474 (NB FishEye's viewcvs mode currently looks for "rev" not "revision" or "r")
diff link	404	https://extranet.atlassian.com/crucible/viewcvs/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?content-type=text/vnd.viewcvs-markup&root=FE&r1=24473&r2=24474
	redirects to	https://extranet.atlassian.com/crucible/browse/FE/FE/trunk/src/java/com/cenqua/crucible/revision/diff/patchDiff/PatchDiff.java?r1=24473&r2=24474
changeset link		absent

Immediate bug fixes

• As shown in example 3, when constructing changeset links, Bamboo should put the WR Module (if present) in the path

• If running in "pure fisheye links" mode
  • don't add content-type and root query params (unecessary in examples 1, 2 and 3)
• If running in "viewcvs compatible mode"
  • Add a rev (in addition to the r and revision) query parameter. (example 4)

Root cause

Bamboo cannot be configured to know that a FishEye repository (or any Web Repository URL) represents a subset of the underlying repository. The examples above don't cover all the possible failure modes because (conveniently) the prefix path "/FE/" coresponds to the name of the repository in the FishEye instance. (Also see BAM-2568)

Possible solutions

• Add a Web Repository Module Prefix parameter, which is the prefix at which the FishEye repository is configured.
• Allow a general regex mechanism for constructing link urls (BAM-1354)
• Add a plugin point for generating SCM links (and for configuring said plugin in the Source Repository plan config page. (related BAM-1602).