Issue Summary

This is reproducible on Data Center: yes

Using a linked repository in a Branch plan we are unable to disable the "Enable repository caching on agents" option.

Steps to Reproduce

1. Create a linked repository to a Bitbucket
2. Create a plan that uses that repository.
3. Configure the plan to create a branch plan on branch creation.
4. Create a new branch on Bitbucket.
5. Edit the repository within the created branch plan.
6. select "Change repository settings for this branch plan"
7. uncheck the setting for "Enable repository caching on agents"
8. Save

Expected Results

The "Enable repository caching on agents" option is disabled.

Actual Results

The "Enable repository caching on agents" remains enabled.

Workaround

1. Stop Bamboo
2. Modify <bamboo-install>/atlassian-bamboo/branch/editChainBranchRepositorySnippet.ftl and change

   •         [@ui.bambooSection id='advanced-configuration']
             ${repo.htmlFragments.advancedServerOptionsHtml!}
             [/@ui.bambooSection]
     

     to

   •         [@ui.bambooSection id='advanced-configuration']
                 [@s.hidden name="___advancedOptionsPresent___" value=true/]
                 ${repo.htmlFragments.advancedServerOptionsHtml!}
             [/@ui.bambooSection]
     

3. Start Bamboo