Linked repository not showing in configureLinkedRepositories

Issue Summary

Linked repository not showing in Bamboo Administration >> Linked Repositories (configureLinkedRepositories) when there is another repository with the same name that is marked for deletion.

Steps to Reproduce

1. Use PostgreSQL
2. Create a Git linked repository called "Test"
3. Link it to a plan
4. Delete the linked repository from Bamboo Administration >> Linked Repositories (admin/configureLinkedRepositories!doDefault.action)
   • It gets marked for deletion in database but does not get removed because its still linked to plan (other dependent data may cause it to not be deleted)
5. Create another Git linked repository with the same name "Test"
6. Restart Bamboo
7. Visit Bamboo Administration >> Linked Repositories, no repository called "Test" will show

Sometimes this doesn't work. We believe it has to do with the order that the repositories come back from the database/get loaded into cache. PostgreSQL order of results when there is no order by is dependent on execution plan, so results may vary.

The steps may need to be executed multiple times or you can get them to not show by switching the marked for deletion flag between the two linked repositories that share the same name, directly in the database and restart.

Expected Results

Repository still shows in the list of repositories

Actual Results

Repository does not show in the list of repositories.

Workaround

The repository can be found at $BAMBOO_BASE_URL/vcs/viewAllRepositories.action

If you know the ID, the edit screen can be directly accessed from $BAMBOO_BASE_URL/admin/editLinkedRepository.action?repositoryId=$REPOSITORY_ID and rename this repository.