Disabling auto-capability detection for the remote agent is not working for new agent

Summary

1. Source-code

    /**
     *  Prevents agents from automatically overriding remote agent capabilities on new startup
     * <p>
     * <ul>
     * <li>Default    : false
     * <li>Usage: <ul><li>env : DISABLE_AGENT_AUTO_CAPABILITY_DETECTION="true"
     *                  <li>java: -DDISABLE_AGENT_AUTO_CAPABILITY_DETECTION=true
     *              </ul>
     * </ul>
     */
    public static final SystemProperty DISABLE_AGENT_AUTO_CAPABILITY_DETECTION = new SystemProperty(false, "DISABLE_AGENT_AUTO_CAPABILITY_DETECTION");

2. Steps to Reproduce

1. stop Bamboo (server)
2. add property to prevent agents from automatically overriding remote agent capabilities on new startup
   <bamboo-install>/bin/setenv.sh, Windows (setenv.bat) - Linux/MacOSX (setenv.sh)

   JVM_SUPPORT_RECOMMENDED_ARGS="-DDISABLE_AGENT_AUTO_CAPABILITY_DETECTION=true"
   

3. start Bamboo server
4. install Bamboo remote agent

   java -Dbamboo.home=/path/to/remote-agent-home -jar atlassian-bamboo-agent-installer-5.9.x.jar http://BAMBOO_BASE_URL/agentServer/
   

3. Expected Results

According to Bamboo's documentation - Disabling auto-capability detection for the remote agent the remote agent should not automatically detect and add capabilities.

There may be situations where you want to prevent Bamboo from automatically detecting and adding capabilities (such as JDKs) to the remote agent, or where you don't want to run the remote agent with default capabilities.

4. Actual Results

By going to "Bamboo administration >> Overview >> Build resources >> Agents" and selecting the "Remote Agent", under "Capabilities" tab we can find a few capabilities listed. The same can be reviewed by running the following SQL query against Bamboo's database:

/* 1507331 is the remote agent id */
select *
  from queue as AGENT
  join capability as CAPABILITY
        on AGENT.capability_set = CAPABILITY.capability_set
 where AGENT.capability_set = 1507331;

As a response from the query above, you can find the following:

5. Notes

In the above example, it was created "<bamboo-agent-home>/bin/bamboo-capabilities.properties"with the following content:

foo=bar

And we can notice the capability was added to the remote agent.