Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-6548

crucible.py script adds fake differences regarding line feeds when linking to git repo

    XMLWordPrintable

Details

    Description

      When creating a review using the crucible.py script from command line and linking to a GIT repo, the added patch includes fake differences about removed line feeds which were not part of the original diff.
      If the script is called without linking to a git repo, then the patch is correctly uploaded.

      Example 1: not link to any repo
      git format-patch -1 -N --stdout | crucible.py -m "title" PROJ @reviewer
      

      Patch is correctly uploaded:

      Example 2: link to a GIT repo
      git format-patch -1 -N --stdout | crucible.py -m "title" -r repo PROJ @reviewer
      

      Patch is uploaded with a fake difference as if a line feed was removed:

      Attachments

        1. 2nd_customer.png
          2nd_customer.png
          9 kB
        2. cru1.png
          cru1.png
          20 kB
        3. cru2.png
          cru2.png
          30 kB

        Issue Links

          Activity

            People

              Unassigned Unassigned
              d0bc506ce7cf Hector Palacios
              Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: