Uploaded image for project: 'Sourcetree for Windows'
  1. Sourcetree for Windows
  2. SRCTREEWIN-8777

git-credential-manager.exe path with whitespace character

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: High High
    • 2.6.7
    • 2.6.6
    • Git

    • Sourcetree v. 2.6.6.0
      Embedded Git v. 2.17.1
      Windows 10

    • Severity 2 - Major

      I cannot fetch, pull or push since having installed the latest update 2.6.6.0 because whenever I do I get the error

       

      C:/Users /Thomas: line1: syntax error near unexpected token `('

       

      I was able to narrow down the search for the cause and found out that it is due to a whitespace character in my Windows user name, e.g. the location of the credential manager is

       

      C:/Users/Thomas Flinkow/AppData/Local/Atlassian/SourceTree/git_extras/git-credential-manager.exe

       

      and it seems to not work because of the whitespace character between "Thomas" and "Flinkow".

      When I move the git-credential-manager.exe to a path that does not contain a whitespace character, everything works fine.

      But I don't want to have to rely on an inconvenient workaround; instead of having to copy & paste every git command to the console, edit the path by hand and execute it then every time I want to fetch, push or pull I want to be able to simply press the buttons in the UI like it was possible before the update.

            [SRCTREEWIN-8777] git-credential-manager.exe path with whitespace character

            minnsey added a comment - - edited

            Thanks for the prompt feedback.

            We will look at rolling out the fix more generally asap.

            minnsey added a comment - - edited Thanks for the prompt feedback. We will look at rolling out the fix more generally asap.

            Thomas Flinkow added a comment -

            Oh, embarrassing, I copied the wrong error message. No idea why I didn't catch that, especially considering that it is 2 years old... but the installation did in fact fail the first time. However, I was able to install Sourcetree v.2.6.7 now and it works perfectly fine as it did before.

            Thank you very much for all your support and the quick fix.

            Thomas Flinkow added a comment - Oh, embarrassing, I copied the wrong error message. No idea why I didn't catch that, especially considering that it is 2 years old... but the installation did in fact fail the first time. However, I was able to install Sourcetree v.2.6.7 now and it works perfectly fine as it did before. Thank you very much for all your support and the quick fix.

            minnsey added a comment -

            Hi

            That is actually a log message form the Squirrel.Windows installer framework we use. It shouldn't actually effect installation, and in fact that message appears to refer to another application MauveSystem3

             

            Can you check to see if there is a %localappdata%/Sourcetree/app-2.6.7 folder? If there is can you run the sourcetree.exe inside it? If not is there anything relevant in the event viewer or in the %localappdata%/Atlassian/Sourcetree/sourcetree.log

            Thanks

            minnsey added a comment - Hi That is actually a log message form the Squirrel.Windows installer framework we use. It shouldn't actually effect installation, and in fact that message appears to refer to another application  MauveSystem3   Can you check to see if there is a %localappdata%/Sourcetree/app-2.6.7 folder? If there is can you run the sourcetree.exe inside it? If not is there anything relevant in the event viewer or in the %localappdata%/Atlassian/Sourcetree/sourcetree.log Thanks

            Thomas Flinkow added a comment -

            Thanks for your efforts. Sadly the setup fails with

             

            2016-09-08 13:56:58> CheckForUpdateImpl: Couldn't write out staging user ID, this user probably shouldn't get beta anything: System.IO.DirectoryNotFoundException: Could not find a part of the path "C:\Users\Thomas Flinkow\AppData\Local\MauveSystem3\packages\.betaId".

             

            Is there anything I need to change in order for the setup to install correctly?

            Thomas Flinkow added a comment - Thanks for your efforts. Sadly the setup fails with   2016-09-08 13:56:58> CheckForUpdateImpl: Couldn 't write out staging user ID, this user probably shouldn' t get beta anything: System .IO.DirectoryNotFoundException: Could not find a part of the path "C:\Users\Thomas Flinkow\AppData\Local\MauveSystem3\packages\.betaId" .   Is there anything I need to change in order for the setup to install correctly?

            minnsey added a comment - - edited

            Hi flinkow

            We believe we have a fix, but were wondering if you would be able to help test it for us, please try the attached 2.6.7 installer.

            This forces the path of the overriding Git Credential Manager into 8.3 format and so effectively masks any spaces in the file path

            https://bitbucket.org/atlassianlabs/sourcetree-betas/downloads/SourceTreeSetup-2.6.7.exe

            minnsey added a comment - - edited Hi flinkow We believe we have a fix, but were wondering if you would be able to help test it for us, please try the attached 2.6.7 installer. This forces the path of the overriding Git Credential Manager into 8.3 format and so effectively masks any spaces in the file path https://bitbucket.org/atlassianlabs/sourcetree-betas/downloads/SourceTreeSetup-2.6.7.exe

            minnsey added a comment -

            Temporary Workaround

            Sourcetree should now find the right GCM version included in the Git install and therefore no longer try to override it.

            minnsey added a comment - Temporary Workaround Download  https://github.com/Microsoft/Git-Credential-Manager-for-Windows/releases/download/v1.16.2/gcmw-v1.16.2.zip extract the contents into the  mingw32\libexec\git-core folder of the Git installation Sourcetree is using. e.g if embedded Git it would go into  %localappdata%\Atlassian\Sourcetree\git_local\mingw32\libexec\git-core confirm the version of the git-credential-manager.exe  in  mingw32\libexec\git-core is 1.16.2 by looking at the properties/details tab. restart Sourcetree Sourcetree should now find the right GCM version included in the Git install and therefore no longer try to override it.

            minnsey added a comment -

            Hi

            Thanks for reporting this. It was unfortunately this wasn't picked up in our testing. I would suggest temporarily downgrading to 2.5.5 and we will get a fix out asap.

            https://downloads.atlassian.com/software/sourcetree/windows/ga/SourceTreeSetup-2.5.5.exe

            FWIW the override is there because the Git credential Manager in 2.17.1.2 is broken and this workaround is intended to override it with a working version.

            Sorry you've been caught out.

            minnsey added a comment - Hi Thanks for reporting this. It was unfortunately this wasn't picked up in our testing. I would suggest temporarily downgrading to 2.5.5 and we will get a fix out asap. https://downloads.atlassian.com/software/sourcetree/windows/ga/SourceTreeSetup-2.5.5.exe FWIW the override is there because the Git credential Manager in 2.17.1.2 is broken and this workaround is intended to override it with a working version. Sorry you've been caught out.

              mminns minnsey
              448e5d4e9ffa Thomas Flinkow
              Affected customers:
              1 This affects my team
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: