Uploaded image for project: 'Sourcetree for Windows'
  1. Sourcetree for Windows
  2. SRCTREEWIN-7634

Pressing 'Enter' Key on Close Button Within Console Output Overlay's Doesn't Work

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Medium Medium
    • None
    • 2.1.2.5
    • UX
    • None
    • Source tree Standalone Application

      Windows 10 64-bit Professional Edition

    • Severity 2 - Major

      Enter key doesn't work on close button in the console output dialog. While seemingly harmless at first glance, if the user checks "Don't show me this message again" when the empty commit prompt displays, it's possible for the user to accidentally commit files prematurely when the enter key is pressed despite the overlay seemingly having the focus.

      (Note that this was not a problem in legacy versions of SourceTree)

      Steps to Reproduce:

      • Have "Always display full console output" option enabled in Source Tree's general options
      • Open any git repo in source tree in "Working Copy" view
      • Perform any change that causes the console dialog overlay to appear (e.g. unstage a file)
      • Console output overlay appears. Note 'Close' button has keyboard focus
      • Press 'Enter' once. (No action takes place)
      • Press 'Enter' a second time. Receive the following prompt "You left the commit message blank. Are you sure you want to commit...?"

      Steps to Workaround

      • Click "Close" manually on any console dialog overlays

              Unassigned Unassigned
              559c4a6bad57 Cleod9
              Votes:
              2 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: