Uploaded image for project: 'Sourcetree for Windows'
  1. Sourcetree for Windows
  2. SRCTREEWIN-7053

Incorrect way of converting english text to uppercase

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Low
    • None
    • 2.0.19.1
    • None
    • Windows 10 1607 English x64
      Using Turkish region format settings

    • Severity 3 - Minor

    Description

      In Turkish locale "i" character and "I" character is different. Therefore when you for example do:

      "file".ToUpper();
      

      It will output "FİLE" and not "FILE" in operating systems which using Turkish locale format for currency, time etc. So my operating system is actually English but because I'm using Turkish for region related settings, it using Turkish rules when converting string to uppercase.

      So solution is to use:

      "file".ToUpperInvariant();
      

      That way it will output "FILE" correctly.

      This issue exists for long time in SourceTree.

      Attachments

        Activity

          People

            Unassigned Unassigned
            c5f804a99d47 Jaex
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: