Uploaded image for project: 'Sourcetree for Windows'
  1. Sourcetree for Windows
  2. SRCTREEWIN-13812

Checkbox 'push changes immediately' is greyed out and cannot be activated

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 3.4.20
    • 3.4.8, 3.4.18, 3.4.19
    • UX
    • None
    • Severity 3 - Minor

      Since the update to 3.4.8 I cannot activate the checkbox 'push changes immediately to origin/master' anymore. It doesn't matter which branch is checked out. The text shows the correct tracked remote branch that already exists (in GitLab, where I want to push to).

      After committing it is possible to push to origin by a simple click on the 'Push' menu button and confirming the following dialog without changing anything.

      This issue came with version 3.4.8. 

            [SRCTREEWIN-13812] Checkbox 'push changes immediately' is greyed out and cannot be activated

            This issue is fixed in the Release '3.4.20'

            Sourcetree-bot added a comment - This issue is fixed in the Release '3.4.20'

            Any news about this issue?

            @dejernet
            I know about this setting, but it changes the default to always push on commit and I don't want to do that every time.

            Why is it not possible to simply enable the checkbox together with the commit button? That's all we need here.

            Christian Ludwig added a comment - Any news about this issue? @dejernet I know about this setting, but it changes the default to always push on commit and I don't want to do that every time. Why is it not possible to simply enable the checkbox together with the commit button? That's all we need here.

            dejernet added a comment -

            Just wanted to chime in on this. Not sure when it was added, but there is an option under "Tools > General > Commit Settings" called "Push to default/origin remote when committing" This automatically checks the box for you, even if it's disabled!!!

            dejernet added a comment - Just wanted to chime in on this. Not sure when it was added, but there is an option under "Tools > General > Commit Settings" called "Push to default/origin remote when committing" This automatically checks the box for you, even if it's disabled!!!

            Unfortunately this UI/UX bug still exists in v3.4.10.

            @Vipin Yadav wrote:
            > So checkbox is also disabled as the commit button. These two will be in sync.

            No, they are not in sync when in the "No staging" view.
            And since v3.4.10 there is a new checkbox "Amend latest commit" which is always changeable and additionally selectable in the dropdown. The UI/UX is not really consistent here.

            And a suggestion to the UI/UX:
            Instead of the checkbox there could be two buttons. One labelled "Commit" and the other, new one labelled "Commit and push" like it is in IntelliJ and PhpStorm.

            Christian Ludwig added a comment - Unfortunately this UI/UX bug still exists in v3.4.10. @Vipin Yadav wrote: > So checkbox is also disabled as the commit button. These two will be in sync. No, they are not in sync when in the "No staging" view. And since v3.4.10 there is a new checkbox "Amend latest commit" which is always changeable and additionally selectable in the dropdown. The UI/UX is not really consistent here. And a suggestion to the UI/UX: Instead of the checkbox there could be two buttons. One labelled "Commit" and the other, new one labelled "Commit and push" like it is in IntelliJ and PhpStorm.

            Is this getting fixed soon? i dont need staging view, just want to commit quickly & easily.

             

            This is why i'm still using old versions.. in fact 1.9 is least worst so far.

            unitycoder added a comment - Is this getting fixed soon? i dont need staging view, just want to commit quickly & easily.   This is why i'm still using old versions.. in fact 1.9 is least worst so far.

            I agree with @Christian Ludwig and @79IT_cms - in previous versions before 3.4.8 of SourceTree, you could check the "push changes immediately to [branch]" when you were in the No Staging view by having one or more files selected.  That makes sense to me... if you're not using staging, I'm confused why it's a problem to allow the checkbox to be selected.  The commit button is disabled until you select one or more files, seems like the "push changes immediately to [branch]" checkbox should follow the same behavior... but it stays disabled regardless of files being selected or not.

            ricke44654 added a comment - I agree with @Christian Ludwig and @79IT_cms - in previous versions before 3.4.8 of SourceTree, you could check the "push changes immediately to [branch] " when you were in the No Staging view by having one or more files selected.  That makes sense to me... if you're not using staging, I'm confused why it's a problem to allow the checkbox to be selected.  The commit button is disabled until you select one or more files, seems like the "push changes immediately to [branch] " checkbox should follow the same behavior... but it stays disabled regardless of files being selected or not.

            79IT_cms added a comment -

            I was hoping the latest release would fix this but I'm pleased that a workaround is possible by changing the view and staging files.

            When using the No staging view it should be possible to select and deselect the Push changes immediately to [branch] checkbox so that I can decide if my commit should be immediately pushed to the origin branch.

            Currently, if a file is staged in split view, when you change back to No staging then the file is ticked and the Push changes immediately to [branch] checkbox is enabled and remains enabled even if you untick all staged files. The Commit button reacts as expected - it's only possible to commit if at least one file has been committed.

            It looks like the Push changes immediately to [branch] checkbox is only enabled when a file is staged in split view.

            It should also be enabled if a file is ticked in No staging too. Optionally, it could also be disabled if no files are ticked.

            79IT_cms added a comment - I was hoping the latest release would fix this but I'm pleased that a workaround is possible by changing the view and staging files. When using the No staging view it should be possible to select and deselect the Push changes immediately to [branch] checkbox so that I can decide if my commit should be immediately pushed to the origin branch. Currently, if a file is staged in split view, when you change back to No staging then the file is ticked and the Push changes immediately to [branch] checkbox is enabled and remains enabled even if you untick all staged files. The Commit button reacts as expected - it's only possible to commit if at least one file has been committed. It looks like the Push changes immediately to [branch] checkbox is only enabled when a file is staged in split view. It should also be enabled if a file is ticked in No staging too. Optionally, it could also be disabled if no files are ticked.

            Christian Ludwig added a comment - - edited

            @Vipin Yadav
            But can you explain me what this is good for in thoughts of UI/UX please?

            I only see disadvantages:

            1. You can't change the checkbox when in the "No staging" view. Neither activate ...

            ... nor deactivate it 

            1. It's not possible to deactivate it when no files are staged. So if you wanted to activate it only for one commit, in the worse case it's not possible to deactivate it afterwards because there are no files to stage anymore. And even when there are files to stage you'll have to stage them, then uncheck the option and finally unstage your files again. So you might forget to uncheck it before the next commit and acidently push all your commits.

             

            Why do you force the user to do this? I would like to understand what the developers intended by adding this restriction.

            (It seems like I'm not allowed to add attachments / images, so please see https://stackoverflow.com/questions/71721460/#72321511 for them)

            Christian Ludwig added a comment - - edited @Vipin Yadav But can you explain me what this is good for in thoughts of UI/UX please? I only see disadvantages: You can't change the checkbox when in the "No staging" view. Neither activate ... ... nor deactivate it  It's not possible to deactivate it when no files are staged. So if you wanted to activate it only for one commit, in the worse case it's not possible to deactivate it afterwards because there are no files to stage anymore. And even when there are files to stage you'll have to stage them, then uncheck the option and finally unstage your files again. So you might forget to uncheck it before the next commit and acidently push all your commits.   Why do you force the user to do this? I would like to understand what the developers intended by adding this restriction. (It seems like I'm not allowed to add attachments / images, so please see https://stackoverflow.com/questions/71721460/#72321511 for them)

            Yes, As you said "If no files are checked in the "No staging" view or no files are staged, you can`t commit and without a commit the files won't get pushed either." So checkbox is also disabled as the commit button. These two will be in sync. If you can not commit then you can not push too.

            Vipin Yadav (Inactive) added a comment - Yes, As you said "If no files are checked in the "No staging" view or no files are staged, you can`t commit and without a commit the files won't get pushed either."  So checkbox is also disabled as the commit button. These two will be in sync. If you can not commit then you can not push too.

            I don't understand what the problem was with this checkbox before v3.4.8. 
            Why shouldn't it be changeable while no files are staged or while you are in the "No staging" view?

            If no files are checked in the "No staging" view or no files are staged, you can`t commit and without a commit the files won't get pushed either.

            Please roll back to the old behaviour.

            Christian Ludwig added a comment - I don't understand what the problem was with this checkbox before v3.4.8.  Why shouldn't it be changeable while no files are staged or while you are in the "No staging" view? If no files are checked in the "No staging" view or no files are staged, you can`t commit and without a commit the files won't get pushed either. Please roll back to the old behaviour.

              698877135425 Mukesh Kumar (Inactive)
              cl1450260031 Christian Ludwig
              Affected customers:
              5 This affects my team
              Watchers:
              12 Start watching this issue

                Created:
                Updated:
                Resolved: