Uploaded image for project: 'Sourcetree For Mac'
  1. Sourcetree For Mac
  2. SRCTREE-978

Unicode combining character is used to express Japanese 'Dakuten'.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • 1.5.0
    • 1.3.3
    • Git
    • None

    • Mac OSX 10.7.3

      Thanks for great app. I want to use Japanese in the commit log, but the combining character string is difficult to read or not display at all.

      I extract the commit objects from .git/objects and check the raw commit message bytes.

      Original Message:
      がぎぐげご

      Commit from Git commandline:
      e3818c e3818e e38190 e38192 e38194

      Commit from Github client:
      e3818c e3818e e38190 e38192 e38194

      Commit from SourceTree:
      e3818b e38299 e3818d e38299 e3818f e38299 e38191 e38299 e38193 e38299

      > The combining characters are rarely used in full-width Japanese characters, as Unicode and all common multibyte Japanese encodings provide precomposed glyphs for all possible dakuten and handakuten character combinations in the standard hiragana and katakana ranges.

            [SRCTREE-978] Unicode combining character is used to express Japanese 'Dakuten'.

            Monique Khairuliana (Inactive) made changes -
            Workflow Original: JAC Bug Workflow v3 [ 3369871 ] New: SRCTREE JAC Bug Workflow [ 3737039 ]
            Monique Khairuliana (Inactive) made changes -
            Workflow Original: SourceTree Bug Workflow [ 381715 ] New: JAC Bug Workflow v3 [ 3369871 ]
            Brian Ganninger (Inactive) made changes -
            Assignee Original: Steve Streeting [ sstreeting ]
            Steve Streeting (Inactive) made changes -
            Link New: This issue is duplicated by SRCTREE-1116 [ SRCTREE-1116 ]
            Steve Streeting (Inactive) made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Reopened [ 4 ] New: Closed [ 6 ]

            Steve Streeting (Inactive) added a comment -

            In 1.5 all commit message data is redirected via a file which avoids NSTask's automatic conversion to decomposed unicode (done to assume compatibility with HPFS+).

            I've tested this with the examples and the original non-decomposed unicode gets through to the commit message correctly.

            Steve Streeting (Inactive) added a comment - In 1.5 all commit message data is redirected via a file which avoids NSTask's automatic conversion to decomposed unicode (done to assume compatibility with HPFS+). I've tested this with the examples and the original non-decomposed unicode gets through to the commit message correctly.

            Kengo Koseki added a comment -

            Thank you so much for reconsidering this issue!

            Kengo Koseki added a comment - Thank you so much for reconsidering this issue!

            Steve Streeting (Inactive) added a comment -

            Actually, hg commit can use the --logfile option, so we should be able to support this there too.

            Steve Streeting (Inactive) added a comment - Actually, hg commit can use the --logfile option, so we should be able to support this there too.
            Steve Streeting (Inactive) made changes -
            Fix Version/s New: 1.5 [ 24991 ]
            Steve Streeting (Inactive) made changes -
            Resolution Original: Won't Fix [ 2 ]
            Status Original: Closed [ 6 ] New: Reopened [ 4 ]

              Unassigned Unassigned
              7d4c0e447b6e Kengo Koseki
              Affected customers:
              0 This affects my team
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: