Uploaded image for project: 'Sourcetree For Mac'
  1. Sourcetree For Mac
  2. SRCTREE-6187

There are many issues with dark theme

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 3.1.2
    • 3.0
    • General
    • None

    • Mac OS

    • Severity 3 - Minor

      • Commit description text-area: The pointer is black on the black background
      • File Change list: text color is pink

       

       

        1. Screen Recording 2018-11-14 at 8.19.14 AM.mov
          2.00 MB

            [SRCTREE-6187] There are many issues with dark theme

            Brian Ganninger (Inactive) added a comment -
            • commit cursor was filed as a separate ticket, fixed in 3.0.1 (November 2018)
            • debug colors now used by Mojave are updated in 3.1.2 (March 2019)

            Please file any future issues as separate tickets after that ships and you are able to verify the changes.

            Brian Ganninger (Inactive) added a comment - commit cursor was filed as a separate ticket, fixed in 3.0.1 (November 2018) debug colors now used by Mojave are updated in 3.1.2 (March 2019) Please file any future issues as separate tickets after that ships and you are able to verify the changes.

            Brian Ganninger (Inactive) added a comment -

            glenn94 PRs welcome, BTCYS.

            Brian Ganninger (Inactive) added a comment - glenn94 PRs welcome, BTCYS.

            GAustin added a comment -

            Not just in dark mode - switch between dark mode and light mode and separators disappear, text colors change when selected and deselected, black text on dark gray background when not active. The list goes on and on.

            GAustin added a comment - Not just in dark mode - switch between dark mode and light mode and separators disappear, text colors change when selected and deselected, black text on dark gray background when not active. The list goes on and on.

            Ola Mårtensson added a comment -

            I have the same issue on my machine even with the latest version of Sourcetree (3.1 (210)) that was released recently. Is fixing this not a priority?

            The current behavior with flapping colors here and there makes the product feel very unpolished and quite unprofessional.

            If the behavior is triggered when macOS dark mode is enabled I would say it should be even higher prioritized - I would assume that anyone who wants to use dark mode in macOS would also like to use Sourcetree (and other third-party apps) in dark mode as well, given that the app supports it.

            Ola Mårtensson added a comment - I have the same issue on my machine even with the latest version of Sourcetree (3.1 (210)) that was released recently. Is fixing this not a priority? The current behavior with flapping colors here and there makes the product feel very unpolished and quite unprofessional. If the behavior is triggered when macOS dark mode is enabled I would say it should be even higher prioritized - I would assume that anyone who wants to use dark mode in macOS would also like to use Sourcetree (and other third-party apps) in dark mode as well, given that the app supports it.

            Brian Ganninger (Inactive) added a comment -

            ebridges Those are typically debug colors introduced for previously unused states. That said, the entire dark theme needs to be vetted on Mojave given the substantial changes made throughout the system to accommodate the mode. It remains on our radar but I don't have an ETA.

            pat750207 Please vote on the ticket, that's the appropriate way to provide a "+1" rather than a comment which doesn't factor in

            Brian Ganninger (Inactive) added a comment - ebridges Those are typically debug colors introduced for previously unused states. That said, the entire dark theme needs to be vetted on Mojave given the substantial changes made throughout the system to accommodate the mode. It remains on our radar but I don't have an ETA. pat750207 Please vote on the ticket, that's the appropriate way to provide a "+1" rather than a comment which doesn't factor in

            Pat_Chang added a comment -

            Same problem here. 

            Pat_Chang added a comment - Same problem here. 

            ebridges added a comment - - edited

            Are the text color changes in the file change list something that it is possible for Atlassian to address?  Or is that something that will have to wait for Apple to correct?

            ebridges added a comment - - edited Are the text color changes in the file change list something that it is possible for Atlassian to address?  Or is that something that will have to wait for Apple to correct?

            Brian Ganninger (Inactive) added a comment -

            The first is a bug that's been addressed in 3.0.1. The latter are regressions introduced by Mojave's dark mode.

            Brian Ganninger (Inactive) added a comment - The first is a bug that's been addressed in 3.0.1. The latter are regressions introduced by Mojave's dark mode.

            Juan Velez added a comment -

            Same problem here. I was on version 2.X and I thought the issue was related for not having upgraded to 3.0. So I did upgrade to 3.0 (200) and the problem is still there as explained by screen recording

            Juan Velez added a comment - Same problem here. I was on version 2.X and I thought the issue was related for not having upgraded to 3.0. So I did upgrade to 3.0 (200) and the problem is still there as explained by screen recording

            Richard Wardin added a comment -

            Can confirm the file change list text color issue in 3.0.1 (mac OS 10.14.1, Dark mode enabled). However it only changes color when selected than de-selected. I've attached a recording to help make it clear what's going on. Screen Recording 2018-11-14 at 8.19.14 AM.mov

            Richard Wardin added a comment - Can confirm the file change list text color issue in 3.0.1 (mac OS 10.14.1, Dark mode enabled). However it only changes color when selected than de-selected. I've attached a recording to help make it clear what's going on.  Screen Recording 2018-11-14 at 8.19.14 AM.mov

              bganninger Brian Ganninger (Inactive)
              4070dda15144 phuluong
              Affected customers:
              11 This affects my team
              Watchers:
              11 Start watching this issue

                Created:
                Updated:
                Resolved: