Uploaded image for project: 'Sourcetree For Mac'
  1. Sourcetree For Mac
  2. SRCTREE-2605

NSTableView crash

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: High High
    • 1.9.8
    • 1.9.7
    • None
    • None

      The screenshot I attached does not reflect the perfect crash state, please read this.

      Referring to the screenshot:
      (B) must be highlighted in the table view
      (A) must not be highlighted in the table view
      I don't know whether (C) is needed for the crash
      (B) and (A) might need to be a new and a modified file

      To cause crash: stage (A) by clicking on the checkpoint without selecting its row first.

        1. crash.txt
          20 kB
        2. Screen Shot 2014-08-05 at 17.56.09.png
          Screen Shot 2014-08-05 at 17.56.09.png
          659 kB

          Form Name

            [SRCTREE-2605] NSTableView crash

            MacAndor added a comment - - edited

            Then there was a condition I missed, but anyways, thank you for taking the time to test and fix it!

            MacAndor added a comment - - edited Then there was a condition I missed, but anyways, thank you for taking the time to test and fix it!

            Steve Streeting (Inactive) added a comment -

            I tried to reproduce it following your exact steps (and a variant just in case) and I can't reproduce any crash; here's my screencast: http://screencast.com/t/QqpYa1yI

            Nevertheless, the crash log indicates that it's a simple row indexing issue which I can guard against even if I can't reproduce it. I've made this change, which will be in the next update.

            Steve Streeting (Inactive) added a comment - I tried to reproduce it following your exact steps (and a variant just in case) and I can't reproduce any crash; here's my screencast: http://screencast.com/t/QqpYa1yI Nevertheless, the crash log indicates that it's a simple row indexing issue which I can guard against even if I can't reproduce it. I've made this change, which will be in the next update.

              Unassigned Unassigned
              5ec9a2cb443d MacAndor
              Affected customers:
              0 This affects my team
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: