Uploaded image for project: 'Sourcetree For Mac'
  1. Sourcetree For Mac
  2. SRCTREE-2556

It's now harder to commit some changes from a file (Git) compared with 1.8

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 1.9.6
    • 1.9.5.1
    • None
    • None
    • OSX 10.9.4

      If you have a changed file from which you wish to commit some changes you can do this in by split view staging mode by staging some hunks, selecting the staged files, and then pressing commit on the menu or toolbar. However if you use my normal workflow and right click in the staging area the view is bounced into 'no staging' mode. (This is the actual bug, right?) The selection is correctly maintained, but any files which are partly staged become fully staged and will be commited as such.

          Form Name

            [SRCTREE-2556] It's now harder to commit some changes from a file (Git) compared with 1.8

            Menu now reads 'Commit Selected' to indicate that it operates on the selected files, and is not the general Commit action.

            Steve Streeting (Inactive) added a comment - Menu now reads 'Commit Selected' to indicate that it operates on the selected files, and is not the general Commit action.

            That would definitely help. I always wondered why right click "Commit" was subtly different from "Commit" on the toolbar. Perhaps also it shouldn't flip to non-staging mode if you selected all the staged files to commit? IIRC 1.8 used to ignore the selection when right click committing from the staging area and just commit the whole stage as Git would tend to do. (Sorry to bring up 1.8 again). Thanks.

            Julian Adams added a comment - That would definitely help. I always wondered why right click "Commit" was subtly different from "Commit" on the toolbar. Perhaps also it shouldn't flip to non-staging mode if you selected all the staged files to commit? IIRC 1.8 used to ignore the selection when right click committing from the staging area and just commit the whole stage as Git would tend to do. (Sorry to bring up 1.8 again). Thanks.

            What I will do is change the text on the right-click menu to 'Commit Selected' to make this clearer.

            Steve Streeting (Inactive) added a comment - What I will do is change the text on the right-click menu to 'Commit Selected' to make this clearer.

            Right-click -> "Commit" is there to 'commit selected' files. This inherently has to flip into non-staging mode because when staging, there is no selection-based commit, you always commit all the staged files. You should be just hitting the Commit toolbar button, or pressing Cmd-Shift-C (which is what I always do) to enter the normal commit mode.

            Steve Streeting (Inactive) added a comment - Right-click -> "Commit" is there to 'commit selected' files. This inherently has to flip into non-staging mode because when staging, there is no selection-based commit, you always commit all the staged files. You should be just hitting the Commit toolbar button, or pressing Cmd-Shift-C (which is what I always do) to enter the normal commit mode.

              Unassigned Unassigned
              643a8669f55d Julian Adams
              Affected customers:
              0 This affects my team
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: