• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Highest Highest
    • 1.9.6
    • 1.9.5
    • None
    • None
    • OSX 10.9.3

      When trying to view the attached as an added file.

          Form Name

            [SRCTREE-2533] SourceTree hangs, seemingly in the preview pane

            Deleted attachment now this issue is fixed as per customer request.

            Steve Streeting (Inactive) added a comment - Deleted attachment now this issue is fixed as per customer request.

            The diff view will now no longer display more than 10,000 characters in a single line in the diff view which avoids the hang. This does mean that operations on individual lines where this has occurred will not work, but this should be a very rare case since line-wise operations where the lines are that long are unlikely.

            Steve Streeting (Inactive) added a comment - The diff view will now no longer display more than 10,000 characters in a single line in the diff view which avoids the hang. This does mean that operations on individual lines where this has occurred will not work, but this should be a very rare case since line-wise operations where the lines are that long are unlikely.

            Thanks. With that the 1.9 series of SourceTree will be undeniably better than 1.8 (for me!)

            Julian Adams added a comment - Thanks. With that the 1.9 series of SourceTree will be undeniably better than 1.8 (for me!)

            The issue seems to be that the first line of that file is 226000 characters long and the Cocoa method for calculating the required width to display that is hanging. We'll put in a trap to just ignore lines that long (you'd never be able to view them anyway).

            Steve Streeting (Inactive) added a comment - The issue seems to be that the first line of that file is 226000 characters long and the Cocoa method for calculating the required width to display that is hanging. We'll put in a trap to just ignore lines that long (you'd never be able to view them anyway).

              Unassigned Unassigned
              643a8669f55d Julian Adams
              Affected customers:
              0 This affects my team
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: