• Icon: Suggestion Suggestion
    • Resolution: Fixed
    • None
    • General
    • Mac
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      The Amend Commit checkbox should not be hidden in a menu.

      1) It's hidden and it's multiple steps to choose it
      2) There is no on-screen indication of when it is turned on
      3) If you subsequently turn it off, there is no visible indication at all that it has been turned off (e.g., the overridden commit message does not revert).
      4) It's hard to find for new users.

      I cannot think of any rationale for hiding this option. In fact, why hide anything in that menu?

            [SRCTREE-2258] Restore Amend Commit checkbox

            Fix is available in version.4.2.7

            Arati Mohanty added a comment - Fix is available in version.4.2.7

            Cross-Commented from SRCTREEWIN-2140 (Regarding Windows v1.6.x+, so not all details may match):

            I would like to add another vote for returning the "Amend Commit" checkbox. My efficiency has crashed since the update changed this. I use the feature constantly and actually never use the "Push changes immediately" feature.

            Making things even worse is that now, when you select "Amend Commit" it also pops up the dialog box about replacing the commit message with the one from the commit you're amending. This happens even if you have not typed anything in the box yet, and also adds an extra carriage return.

            In all, this means that what used to be a single checkbox click is now "click a menu, click the option, click OK on the dialog box, click in the commit message box, delete the extra carriage return". This is ridiculous. Please do something about this.

            Thank you.

            Bethany Jokinen added a comment - Cross-Commented from SRCTREEWIN-2140 (Regarding Windows v1.6.x+, so not all details may match): I would like to add another vote for returning the "Amend Commit" checkbox. My efficiency has crashed since the update changed this. I use the feature constantly and actually never use the "Push changes immediately" feature. Making things even worse is that now, when you select "Amend Commit" it also pops up the dialog box about replacing the commit message with the one from the commit you're amending. This happens even if you have not typed anything in the box yet, and also adds an extra carriage return. In all, this means that what used to be a single checkbox click is now "click a menu, click the option, click OK on the dialog box, click in the commit message box, delete the extra carriage return". This is ridiculous. Please do something about this. Thank you.

            Jeff Wong added a comment -

            I like minimalism, but mistakenly leaving the check on can create confusing branch states, which requires me feel uncertain about my understanding of git, which is something you don't want as people are using SourceTree because it reduces the learning curve of git.

            What I did just now, was "Amend Commit" and then realized that I had already pushed the last commit, so I hit "Cancel" then I went to go do it again not realizing that my setting had been saved from last time.

            Jeff Wong added a comment - I like minimalism, but mistakenly leaving the check on can create confusing branch states, which requires me feel uncertain about my understanding of git, which is something you don't want as people are using SourceTree because it reduces the learning curve of git. What I did just now, was "Amend Commit" and then realized that I had already pushed the last commit, so I hit "Cancel" then I went to go do it again not realizing that my setting had been saved from last time.

            This is another case where UI elements that are just as important as indicators as well as toggles got shunted in 1.9.

            Amend commit is something I do quite a bit - having to seek far off to the right of the screen, click a menu, seek again, click the amend option, wander back, hope that it's still on even though I can't see it, is annoying and disconcerting.

            In the 1.8 dialog, it was obvious and easy to access.

            I'd second the comments from Roy about organization - something like a checkbox button panel at the bottom of the old dialog with shorter names might have avoided confusion among new users, but left the option quickly accessible.
            And if 'amend' is an advanced or confusing option worth hiding like an ejector seat lever, you'd have to seriously consider who the target audience for SourceTree is. I think I started using it on day one of using Git.

            Tim Whittington added a comment - This is another case where UI elements that are just as important as indicators as well as toggles got shunted in 1.9. Amend commit is something I do quite a bit - having to seek far off to the right of the screen, click a menu, seek again, click the amend option, wander back, hope that it's still on even though I can't see it, is annoying and disconcerting. In the 1.8 dialog, it was obvious and easy to access. I'd second the comments from Roy about organization - something like a checkbox button panel at the bottom of the old dialog with shorter names might have avoided confusion among new users, but left the option quickly accessible. And if 'amend' is an advanced or confusing option worth hiding like an ejector seat lever, you'd have to seriously consider who the target audience for SourceTree is. I think I started using it on day one of using Git.

            Roy Leban added a comment -

            Here's the tradeoff you're making: while reducing a bit of clutter for people who don't use the option, you are causing mistakes among people who do use the option. This is a bad tradeoff. Having Amend Commit hidden makes it hard to use. But to have the current setting also be hidden is a huge mistake – it is bad enough that I will continue to use 1.8 even after you make all the other fixes in 1.9.x (which I do appreciate).

            As somebody who has done UX work for more than 25 years, I can tell you that the solution to confusion with the number of options is most definitely not to hide things and change text buttons to confusing icons (see SRCTREE-2260). The solution is proper organization so it isn't confusing and doesn't look like clutter.

            Roy Leban added a comment - Here's the tradeoff you're making: while reducing a bit of clutter for people who don't use the option, you are causing mistakes among people who do use the option. This is a bad tradeoff. Having Amend Commit hidden makes it hard to use. But to have the current setting also be hidden is a huge mistake – it is bad enough that I will continue to use 1.8 even after you make all the other fixes in 1.9.x (which I do appreciate). As somebody who has done UX work for more than 25 years, I can tell you that the solution to confusion with the number of options is most definitely not to hide things and change text buttons to confusing icons (see SRCTREE-2260 ). The solution is proper organization so it isn't confusing and doesn't look like clutter.

            Unfortunately what is considered balanced does very much depend on your experience level, and git is now attracting a wider range of developers than it did a couple of years ago. We did user tests with a range of developers and confusion about the number of options at the top level of the commit dialog definitely came up a lot.

            Steve Streeting (Inactive) added a comment - Unfortunately what is considered balanced does very much depend on your experience level, and git is now attracting a wider range of developers than it did a couple of years ago. We did user tests with a range of developers and confusion about the number of options at the top level of the commit dialog definitely came up a lot.

            Out of curiosity, where does this feedback come from? Sourcetree is a developers tool. I don't think anyone expects it to be without a little clutter, but 1.8.1 had a good balance. 1.9.x does not.

            Kaveh Vaghefi added a comment - Out of curiosity, where does this feedback come from? Sourcetree is a developers tool. I don't think anyone expects it to be without a little clutter, but 1.8.1 had a good balance. 1.9.x does not.

            In fact, why hide anything in that menu

            We've received feedback that the commit screen was too cluttered & confusing for new users. Tracking this in our UX feedback stream.

            Steve Streeting (Inactive) added a comment - In fact, why hide anything in that menu We've received feedback that the commit screen was too cluttered & confusing for new users. Tracking this in our UX feedback stream.

              2566180e0bc8 Arati Mohanty
              9c8da6815a99 Roy Leban
              Votes:
              39 Vote for this issue
              Watchers:
              25 Start watching this issue

                Created:
                Updated:
                Resolved: