Uploaded image for project: 'Confluence Source Editor Plugin'
  1. Confluence Source Editor Plugin
  2. SOURCE-68

Source editor use of CodeMirror clashes with other plugins

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • 1.0.4
    • 1.0.3
    • None

    • Confluence 4.1.6 + Theme Builder 4.3.1

    • true

      We've just installed the source editor on our intranet, very nice it is too, thanks. Only we've just discovered that its use of CodeMirror clashes with the version of CodeMirror used in Theme Builders admin pages.

      Is there any chance you could restrict the context of your web-resources to avoid being included when not required?

      To replicate:

      • Install both plugins
      • Go to Admin > Manage Builder Layouts
      • Select the CSS tab
      • Click 'Edit Custom CSS'
      • You'll see a dialog appear with 'Custom CSS' tab and a grey area - this should be a white CodeMirror editor.

      Cheers
      Mark Gibson (Developer, Adaptavist)

        1. source-68.patch
          2 kB
          Mark Gibson

            [SOURCE-68] Source editor use of CodeMirror clashes with other plugins

            Petch (Inactive) added a comment -

            Great, thanks for confirming it's all fixed.

            Petch (Inactive) added a comment - Great, thanks for confirming it's all fixed.

            Mark Gibson added a comment -

            Awesome, thanks Craig.

            Mark Gibson added a comment - Awesome, thanks Craig.

            Mohamed Gargouri added a comment -

            Thank you very much for this update. I just updated to the v. 1.0.4 and no more conflict with TemeBuilder. We are using the Confluence v4.2.13 and TB v4.3.1.
            Well done!

            Mohamed Gargouri added a comment - Thank you very much for this update. I just updated to the v. 1.0.4 and no more conflict with TemeBuilder. We are using the Confluence v4.2.13 and TB v4.3.1. Well done!

            Petch (Inactive) added a comment -

            mgibson - let me know if you find any issues with 1.0.4 of the plugin (and which versions of Confluence you experience them on).

            Petch (Inactive) added a comment - mgibson - let me know if you find any issues with 1.0.4 of the plugin (and which versions of Confluence you experience them on).

            Petch (Inactive) added a comment -

            The source editor resources were being included in all pages, instead of only where the editor is actually used.

            Restricted to only load the source editor resources where the editor appears.

            Petch (Inactive) added a comment - The source editor resources were being included in all pages, instead of only where the editor is actually used. Restricted to only load the source editor resources where the editor appears.

            Petch (Inactive) added a comment -

            mgibson - I'll sort this out today for you. Apologies.

            Petch (Inactive) added a comment - mgibson - I'll sort this out today for you. Apologies.

            Mark Gibson added a comment -

            This is getting really annoying. We use CodeMirror in a couple of our plugins and this just clobbers it for us.

            The fix is really simple, heres a patch.

            Is there any chance the source for this plugin is going to get opened up on bitbucket? It's a really great tool but it seems to have stagnated.

            Cheers.

            Mark Gibson added a comment - This is getting really annoying. We use CodeMirror in a couple of our plugins and this just clobbers it for us. The fix is really simple, heres a patch. Is there any chance the source for this plugin is going to get opened up on bitbucket? It's a really great tool but it seems to have stagnated. Cheers.

            Petch (Inactive) added a comment - - edited

            Hi mgibson.

            I put the on our backlog. I'll get it scheduled in the next sprint or two (we're close to summit and 4.3 so flat out with that).

            Craig

            P.S. Thanks for letting us know.

            Petch (Inactive) added a comment - - edited Hi mgibson . I put the on our backlog. I'll get it scheduled in the next sprint or two (we're close to summit and 4.3 so flat out with that). Craig P.S. Thanks for letting us know.

              cpetchell Petch (Inactive)
              f9cc6b563220 Mark Gibson
              Archiver:
              mkhairuliana Monique Khairuliana (Inactive)

                Created:
                Updated:
                Resolved:
                Archived:
                12 years, 29 weeks, 6 days ago

                  Estimated:
                  Original Estimate - 4h
                  4h
                  Remaining:
                  Remaining Estimate - 4h
                  4h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified