NPE when request.getQueryString() is null

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: Low
    • 3.1
    • Affects Version/s: 3.1
    • None

      SER-199 introduced changes that will NPE when the query string is null. Since that is what happens when no query string is provided, it pretty much kills everything:

      Sep 11, 2014 1:48:11 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet [default] in context with path [/jira] threw exception
java.lang.NullPointerException
	at java.net.URLDecoder.decode(URLDecoder.java:136)
	at com.atlassian.seraph.filter.LoginFilter.decodeQueryString(LoginFilter.java:79)
	at com.atlassian.seraph.filter.LoginFilter.extractUserPasswordPair(LoginFilter.java:94)
	at com.atlassian.seraph.filter.PasswordBasedLoginFilter.login(PasswordBasedLoginFilter.java:58)
	at com.atlassian.seraph.filter.BaseLoginFilter.doFilter(BaseLoginFilter.java:110)
	at com.atlassian.jira.web.filters.JiraLoginFilter.doFilter(JiraLoginFilter.java:70)

            Assignee:
            crf
            Reporter:
            crf
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: