Uploaded image for project: 'atlassian-seraph'
  1. atlassian-seraph
  2. SER-201

NPE when request.getQueryString() is null

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Low
    • 3.1
    • 3.1
    • None
    • false

    Description

      SER-199 introduced changes that will NPE when the query string is null. Since that is what happens when no query string is provided, it pretty much kills everything:

      Sep 11, 2014 1:48:11 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet [default] in context with path [/jira] threw exception
java.lang.NullPointerException
	at java.net.URLDecoder.decode(URLDecoder.java:136)
	at com.atlassian.seraph.filter.LoginFilter.decodeQueryString(LoginFilter.java:79)
	at com.atlassian.seraph.filter.LoginFilter.extractUserPasswordPair(LoginFilter.java:94)
	at com.atlassian.seraph.filter.PasswordBasedLoginFilter.login(PasswordBasedLoginFilter.java:58)
	at com.atlassian.seraph.filter.BaseLoginFilter.doFilter(BaseLoginFilter.java:110)
	at com.atlassian.jira.web.filters.JiraLoginFilter.doFilter(JiraLoginFilter.java:70)

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. SER-199 Make support for os_username and os_password as url parameters require opting in

          • Low - Low priority issues
          • RESOLVED

          Activity

            People

              cfuller crf
              cfuller crf
              crf
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9 years, 34 weeks, 1 day ago