Issue Summary

Since NFS fixer pod has a pre-install hook annotation, Helm processes this template before it looks at others. This pod uses a PVC which Helm can create for you but it happens only after pre-install things are completed. It results in nfs fixer pod just sitting there in a pending state since it share-home PVC is never created.

GitHub issue: https://github.com/atlassian-labs/data-center-helm-charts/issues/75

Steps to Reproduce

1. Deploy any DC product with Helm with

{{ --set volumes.sharedHome.persistentVolumeClaim.create=true }}
--set volumes.sharedHome.nfsPermissionFixer.enabled=true

Expected Results

NFS fixer pod does its job and the installation continues

Actual Results

NFS fixer pod stuck in a pending state because of a missing PVC:

NAME                        READY   STATUS    RESTARTS   AGE
bitbucket-nfs-fixer-jvx5n   0/1     Pending   0          4m51s
postgres-postgresql-0       1/1     Running   0          14m

Events:
  Type     Reason            Age    From               Message
  ----     ------            ----   ----               -------
  Warning  FailedScheduling  6m54s  default-scheduler  persistentvolumeclaim "bitbucket-shared-home" not found
  Warning  FailedScheduling  5m30s  default-scheduler  persistentvolumeclaim "bitbucket-shared-home" not found

Workaround

Removing pre-install hook annotation is a workaround but very unreliable since the pod can start after Jira/Connie/BBDC starts writing to share home.