Uploaded image for project: 'Jira Software Data Center'
  1. Jira Software Data Center
  2. JSWSERVER-14897

JIRA development panel can't displayed "Reviews" with Draft state

      Steps to reproduce the problem:

      1. Create an Application Link between JIRA 6.3.15 and Crucible 3.6.3.
      2. Create a new "Review" called CR-11 and attach a linked issue (SSAB-120) to it, see draft-review.png. Then, click Done button.
      3. Click Reviews via Issue Screen and CR-11 review is not shows in the Development Panel, see dev-panel.png
      4. There is a REST request trigger in Fisheye log when clicking on the Reviews link in Development Panel, i.e
        15-03-20 16:06:46,706 DEBUG [qtp2058143701-264 ] fisheye ProfilingServletFilter-logRequest - start request GET /rest/dev-status/1.0/details/reviews?xoauth_requestor_id=admin&globalId=SSAB-120&globalId=SSP-120 sessionid=npl3apxnivz61pv1z70engnx4
        2015-03-20 16:06:46,736 DEBUG [qtp2058143701-264 ] fisheye ProfilingServletFilter-logRequest - end request in 29ms GET /rest/dev-status/1.0/details/reviews?xoauth_requestor_id=admin&globalId=SSAB-120&globalId=SSP-120 sessionid=npl3apxnivz61pv1z70engnx4 200
      5. Copy & paste the URL (http://johnchin-pc:8060/rest/dev-status/1.0/details/reviews?xoauth_requestor_id=admin&globalId=SSAB-120&globalId=SSP-120) into the web browser and show the results below:
        {"reviews":[{"id":"CR-9","url":"http://johnchin-pc:8060/cru/CR-9","state":"REVIEW","title":"","dueDate":"2015-03-26T16:00:00.000+0800","lastModified":"2015-03-20T15:59:45.085+0800","commentCount":0,"author":{"name":"admin","avatar":"http://johnchin-pc:8060/avatar/admin?s=48"},"moderator":{"name":"admin","avatar":"http://johnchin-pc:8060/avatar/admin?s=48"},"reviewers":[]},{"id":"CR-10","url":"http://johnchin-pc:8060/cru/CR-10","state":"REVIEW","title":"","dueDate":"2015-03-27T16:00:00.000+0800","lastModified":"2015-03-20T16:03:47.449+0800","commentCount":0,"author":{"name":"admin","avatar":"http://johnchin-pc:8060/avatar/admin?s=48"},"moderator":{"name":"admin","avatar":"http://johnchin-pc:8060/avatar/admin?s=48"},"reviewers":[]},{"id":"CR-11","url":"http://johnchin-pc:8060/cru/CR-11","state":"DRAFT","title":"","dueDate":"2015-03-27T16:00:00.000+0800","lastModified":"2015-03-20T16:06:32.411+0800","commentCount":0,"author":{"name":"admin","avatar":"http://johnchin-pc:8060/avatar/admin?s=48"},"moderator":{"name":"admin","avatar":"http://johnchin-pc:8060/avatar/admin?s=48"},"reviewers":[]}]}
        

      As you can see, CR-11 review shows in the returned values.

      Workaround:

      Change the review state to Start Review.

        1. dev-panel.png
          dev-panel.png
          122 kB
        2. draft-review.png
          draft-review.png
          128 kB

            [JSWSERVER-14897] JIRA development panel can't displayed "Reviews" with Draft state

            Owen made changes -
            Workflow Original: JAC Bug Workflow v2 [ 2854083 ] New: JAC Bug Workflow v3 [ 2935096 ]
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]
            Owen made changes -
            Symptom Severity Original: Minor [ 14432 ] New: Severity 3 - Minor [ 15832 ]
            Owen made changes -
            Workflow Original: JIRA Bug Workflow w Kanban v7 - Restricted [ 2542787 ] New: JAC Bug Workflow v2 [ 2854083 ]
            Ignat (Inactive) made changes -
            Workflow Original: JIRA Bug Workflow w Kanban v6 - Restricted [ 1536334 ] New: JIRA Bug Workflow w Kanban v7 - Restricted [ 2542787 ]
            Oswaldo Hernandez (Inactive) made changes -
            Component/s New: Development Panel [ 43313 ]
            Component/s Original: Issue - Development Panel [ 25405 ]
            Key Original: JRA-42539 New: JSW-14897
            Symptom Severity New: Minor [ 14432 ]
            Affects Version/s Original: 6.3.15 [ 50826 ]
            Project Original: JIRA (including JIRA Core) [ 10240 ] New: JIRA Software (including JIRA Agile) [ 12200 ]
            Oswaldo Hernandez (Inactive) made changes -
            Labels Original: warranty New: jira-development-panel warranty
            Owen made changes -
            Workflow Original: JIRA Bug Workflow w Kanban v6 [ 844162 ] New: JIRA Bug Workflow w Kanban v6 - Restricted [ 1536334 ]

            Hi,

            Adding to Graeme and Adam's comments, hiding Draft, Abandoned and Summarized code reviews in JIRA tickets is hindering users on knowing the status of its related ticket. One case that I can come up is workflow conditions: It's well known that a transition could happen if all code reviews gets closed or not. But by hiding the draft CR, users would transition without knowing all information of the issue. (Please see the suggestion JSW-13425)

            Please, reconsider this ticket and include the non-Open-Under Review-Close Code Review. It is totally important for developers to review what is going on with their tickets.

            Darly Senecal-Baptiste added a comment - Hi, Adding to Graeme and Adam's comments, hiding Draft, Abandoned and Summarized code reviews in JIRA tickets is hindering users on knowing the status of its related ticket. One case that I can come up is workflow conditions: It's well known that a transition could happen if all code reviews gets closed or not. But by hiding the draft CR, users would transition without knowing all information of the issue. (Please see the suggestion JSW-13425 ) Please, reconsider this ticket and include the non-Open-Under Review-Close Code Review. It is totally important for developers to review what is going on with their tickets.

            Considering a review in Draft status can be viewed by users other than the author (and indeed comments can be added to them) it seems wrong for them to be omitted in JIRA. In JIRA there's no visual difference between a review not existing at all and one existing in Draft status. Even if users other than the author should not be looking at the Draft review, I don't see why it would be wrong to indicate that a Draft review exists.

            adcooperman added a comment - Considering a review in Draft status can be viewed by users other than the author (and indeed comments can be added to them) it seems wrong for them to be omitted in JIRA. In JIRA there's no visual difference between a review not existing at all and one existing in Draft status. Even if users other than the author should not be looking at the Draft review, I don't see why it would be wrong to indicate that a Draft review exists .
            Gustavo Refosco (Inactive) made changes -
            Link New: This issue relates to JRA-44269 [ JRA-44269 ]

              Unassigned Unassigned
              ckimloong John Chin
              Affected customers:
              0 This affects my team
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: